Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State diffs #868

Closed
wants to merge 10 commits into from
Closed

State diffs #868

wants to merge 10 commits into from

Conversation

AminArria
Copy link
Contributor

@AminArria AminArria commented Aug 16, 2024 •
edited
Loading

Motivation

In preparation for sending state diffs rather than entire state

Summary of changes

  • Add functiondiff/2 to calculate diff of 2 terms
  • Commented out code to send diff state
  • Adapted broadcast code to allow for missing fields

How to test it?

Code is commented out so nothing will change, but feel free to uncomment the call to diff/2 and run some games to make sure it does not crash

Checklist

  • Tested the changes locally.
  • Reviewed the changes on GitHub, line by line.
  • This change requires new documentation.
    • Documentation has been added/updated.

@AminArria AminArria marked this pull request as ready for review August 19, 2024 19:49
@AminArria AminArria changed the title WIP state diffs State diffs Aug 20, 2024
@AminArria AminArria marked this pull request as draft August 20, 2024 17:33
@AminArria AminArria marked this pull request as ready for review August 20, 2024 19:12
@AminArria AminArria marked this pull request as draft August 21, 2024 19:52
@AminArria
Copy link
Contributor Author

Included in #888

@AminArria AminArria closed this Sep 9, 2024
@AminArria AminArria deleted the state-diffs branch September 9, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AminArria @Nico-Sanchez