Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RELEASE_NODE in brazil testing only #826

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

Nico-Sanchez
Copy link
Collaborator

@Nico-Sanchez Nico-Sanchez commented Aug 1, 2024

Motivation

We were using RELEASE_NODE in every server, even if we deploy 1 node only.
This breaks the app remote command (attach to iex), because you have to specify the node you want to attach to.

Summary of changes

Use RELEASE_NODE in brazil testing only

How to test it?

Deploy to any server you want.
You would be able to connect to the iex without any problem. For brazil arena testing, you have to specify the RELEASE_NODE.

Checklist

  • Tested the changes locally.
  • Reviewed the changes on GitHub, line by line.
  • This change requires new documentation.
    • Documentation has been added/updated.

@Nico-Sanchez Nico-Sanchez force-pushed the fix-iex-no-connection-error branch from 712cc22 to 213df11 Compare August 1, 2024 18:27
Copy link
Contributor

@agustinesco agustinesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AminArria AminArria merged commit 10a30a5 into main Aug 2, 2024
4 of 5 checks passed
@AminArria AminArria deleted the fix-iex-no-connection-error branch August 2, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants