Gh 692 allow client to toggle bots #693
Conversation
Nico-Sanchez
changed the base branch from
main
to
gh-687-allow-client-to-toggle-zone
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| event: {:toggle_bots, %ToggleBots{}} | ||
| }) | ||
|
|
||
| PubSub.broadcast(Arena.PubSub, state.game_state.game_id, {:toggle_bots, encoded_msg}) |
There was a problem hiding this comment.
Why is this message broadcasted to the clients? The only difference turning on or off the bots makes to them is received through the GameState message, they don't handle this message in any way.
Client PR for reference: [GH-1831] Add toggle bots button
There was a problem hiding this comment.
The bots are clients as well. Said so, the bots ARE handling that message to change its state.
You can check it in apps/bot_manager/lib/game_socket_handler.ex
Also, remember the bots are deployed in a different server than where the backend runs (arena), so we need to send the message somehow (I use this broadcast for that)
|
Other small thing, the client PR referenced in the description is closed, there is a new one to link! |
manucamejo
temporarily deployed
to
testing-brazil
GitHub Actions
Inactive
manucamejo
temporarily deployed
to
testing-brazil
GitHub Actions
Inactive
manucamejo
temporarily deployed
to
testing-brazil
GitHub Actions
Inactive
manucamejo
temporarily deployed
to
testing-brazil
GitHub Actions
Inactive
manucamejo
temporarily deployed
to
testing-europe
GitHub Actions
Inactive
manucamejo
temporarily deployed
to
testing-brazil
GitHub Actions
Inactive
|
@Nico-Sanchez Remember to redeploy the bots server when this PR gets merged |
agustinesco
temporarily deployed
to
testing-brazil
GitHub Actions
Inactive
agustinesco
temporarily deployed
to
testing-brazil
GitHub Actions
Inactive
agustinesco
temporarily deployed
to
testing-brazil
GitHub Actions
Inactive
manucamejo
had a problem deploying
to
testing-europe
GitHub Actions
Failure
manucamejo
had a problem deploying
to
testing-brazil
GitHub Actions
Failure
Important
This PR must be merged along with https://github.com/lambdaclass/champions_of_mirra/pull/1840
Motivation
We must allow clients to enable and disable the bots.
Closes #692
Summary of changes
How to test it?
Play a game with the following client branch -> https://github.com/lambdaclass/champions_of_mirra/pull/1833
Toggle the BOTS in settings > dev tab > utils.
Checklist