Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add google client ID to central backend deployment #626

Merged
merged 1 commit into from
May 16, 2024
Merged

Add google client ID to central backend deployment #626

merged 1 commit into from
May 16, 2024

Conversation

Nico-Sanchez
Copy link
Collaborator

@Nico-Sanchez Nico-Sanchez commented May 16, 2024 •
edited
Loading

Motivation

GOOGLE_CLIENT_ID was not being set up in central backend app.

Summary of changes

Add google client ID to central backend deployment

How to test it?

We must deploy and log in with google.

Checklist

  • Tested the changes locally.
  • Reviewed the changes on GitHub, line by line.
  • This change requires new documentation.
    • Documentation has been added/updated.

agustinesco
agustinesco approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@agustinesco agustinesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvillegas98 tvillegas98 merged commit beac49d into main May 16, 2024
2 checks passed
@tvillegas98 tvillegas98 deleted the add-google-client-id-to-deployment-yml branch May 16, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agustinesco agustinesco agustinesco approved these changes

@tvillegas98 tvillegas98 tvillegas98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nico-Sanchez @tvillegas98 @agustinesco