Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-604] Spawn power ups outside colliders #623

Merged
merged 1 commit into from
May 15, 2024
Merged

[GH-604] Spawn power ups outside colliders #623

merged 1 commit into from
May 15, 2024

Conversation

manucamejo
Copy link
Collaborator

Motivation

The power ups were spawning inside colliders
Closes #604

Summary of changes

  • Check if the position collides with an obstacle and if that happens, get a new position.

Checklist

  • Tested the changes locally.
  • Reviewed the changes on GitHub, line by line.
  • This change requires new documentation.
    • Documentation has been added/updated.

agustinesco
agustinesco approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@agustinesco agustinesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nice approach to fixing this, we should keep in mind that this may suffer from the same probably issue were we end up in an infinity cicle

image

@tvillegas98 tvillegas98 merged commit d998779 into main May 15, 2024
1 check passed
@tvillegas98 tvillegas98 deleted the gh-604-power-ups-should-spawn-outside-colliders branch May 15, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agustinesco agustinesco agustinesco approved these changes

@tvillegas98 tvillegas98 tvillegas98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Power-ups should spawn outside the colliders
3 participants
@manucamejo @tvillegas98 @agustinesco