Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gateway.proto #620

Merged
merged 1 commit into from
May 14, 2024
Merged

Fix gateway.proto #620

merged 1 commit into from
May 14, 2024

Conversation

lotuuu
Copy link
Contributor

@lotuuu lotuuu commented May 14, 2024

Motivation

We introduced a change that was breaking tests, but since we forgot to run make generate-protos we didn't notice it until someone else ran it for a different PR.

Since this id is needed for tests, it makes no sense to remove it, so we will restore the changes.

@lotuuu lotuuu self-assigned this May 14, 2024
Copy link
Contributor

@agustinesco agustinesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Nico-Sanchez Nico-Sanchez merged commit df29d15 into main May 14, 2024
1 check passed
@Nico-Sanchez Nico-Sanchez deleted the fix-gateway-proto branch May 14, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants