Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-616] Add client config json #619

Merged
merged 30 commits into from
Jun 3, 2024
Merged

[GH-616] Add client config json #619

merged 30 commits into from
Jun 3, 2024

Conversation

Nico-Sanchez
Copy link
Collaborator

@Nico-Sanchez Nico-Sanchez commented May 14, 2024 •
edited
Loading

⚠️ DISCLAIMER ⚠️
This has to be merged with https://github.com/lambdaclass/champions_of_mirra/pull/1798

Motivation

Client developers need a faster way to test their changes. Without this, they have to rebuild every time.
Closes #616
This is the config for 30th May's playtest.

Summary of changes

How to test it?

You can test it with the following branch -> https://github.com/lambdaclass/champions_of_mirra/pull/1798

Checklist

  • Tested the changes locally.
  • Reviewed the changes on GitHub, line by line.
  • This change requires new documentation.
    • Documentation has been added/updated.

@Nico-Sanchez Nico-Sanchez changed the title Gh 616 add client config json [GH-616] Add client config json May 14, 2024
@Nico-Sanchez Nico-Sanchez marked this pull request as ready for review May 14, 2024 20:59
tvillegas98
tvillegas98 previously approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@tvillegas98 tvillegas98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well!

@agustinesco agustinesco marked this pull request as draft May 22, 2024 15:51
@tkz00 tkz00 temporarily deployed to testing-brazil May 30, 2024 02:03 — with GitHub Actions Inactive
@Nico-Sanchez Nico-Sanchez added waiting on PR Waiting on another PR in this repo or in the client repo and removed wip labels May 30, 2024
@Nico-Sanchez Nico-Sanchez marked this pull request as ready for review May 30, 2024 15:00
tvillegas98
tvillegas98 approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@tvillegas98 tvillegas98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work again! 🚀

@manucamejo manucamejo merged commit 5b3cc7a into main Jun 3, 2024
3 checks passed
@manucamejo manucamejo deleted the gh-616-add-client-config-json branch June 3, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvillegas98 tvillegas98 tvillegas98 approved these changes

@manucamejo manucamejo manucamejo approved these changes

@AminArria AminArria AminArria approved these changes

Assignees
No one assigned
Labels
champions MOBA game waiting on PR Waiting on another PR in this repo or in the client repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Create config for client
9 participants
@Nico-Sanchez @AminArria @manucamejo @tvillegas98 @mgrunwaldt @tkz00 @AngieDutra @agustinesco @saugon