Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-607] Only spawn bots if player is alive #608

Merged
merged 2 commits into from
May 14, 2024

Conversation

agustinesco
Copy link
Contributor

Motivation

We were spawning bots that could move when a dead player leaves a match.

Closes #607

Summary of changes

  • Now we'll only spawn bots if the player is alive, we're updating the enable field when a player dies so we'll use that

How to test it?

  1. Change the players_needed_in_match variable to 3
  2. Join a match with the browser client and the unity client
  3. Die to the spawned bot in the unity client and leave the match
  4. In main you'll see that the dead players is moving
  5. In this branch that shouldn't happen

Checklist

  • Tested the changes locally.
  • Reviewed the changes on GitHub, line by line.
  • This change requires new documentation.
    • Documentation has been added/updated.

@lotuuu lotuuu added the champions MOBA game label May 13, 2024
@Nico-Sanchez Nico-Sanchez merged commit 2d5684a into main May 14, 2024
1 check passed
@Nico-Sanchez Nico-Sanchez deleted the gh-607-avoid-spawning-bots-for-dead-players branch May 14, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
champions MOBA game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Dead players are being controlled by bots
4 participants