[GH-599] Add crates to config #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agustinesco
had a problem deploying
to
testing-brazil
GitHub Actions
Failure
agustinesco
had a problem deploying
to
testing-brazil
GitHub Actions
Failure
agustinesco
had a problem deploying
to
testing-brazil
GitHub Actions
Failure
agustinesco
temporarily deployed
to
testing-brazil
GitHub Actions
Inactive
AminArria
reviewed
May 10, 2024
config/config.exs
Outdated
| # Application.app_dir(:game_backend, "priv/currencies_rules.json") | ||
| # |> File.read() | ||
|
|
||
| # config :game_backend, :currencies_config, Jason.decode!(currency_config_json) |
There was a problem hiding this comment.
Why the move and commented out?
There was a problem hiding this comment.
There was an error in the playtest, i'll restore this in this pr and fix it in a pr
agustinesco
temporarily deployed
to
testing-brazil
GitHub Actions
Inactive
Nico-Sanchez
previously approved these changes
May 13, 2024
AminArria
previously approved these changes
May 13, 2024
marco-paulucci
dismissed stale reviews from AminArria and Nico-Sanchez
via
0d0fa22
marco-paulucci
approved these changes
May 14, 2024
AminArria
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We needed crates
Waiting on: https://github.com/lambdaclass/curse_of_mirra/pull/1676
Closes #599
Summary of changes
How to test it?
Start a game and see the crates
Checklist