Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-580] Fake Item and Traps #598

Merged
merged 51 commits into from
May 20, 2024
Merged

[GH-580] Fake Item and Traps #598

merged 51 commits into from
May 20, 2024

Conversation

tvillegas98
Copy link
Contributor

@tvillegas98 tvillegas98 commented May 10, 2024

Motivation

Add the new fake item to the game and also add the new traps feature.

Closes #580
After merging this, lets merge https://github.com/lambdaclass/curse_of_mirra/pull/1772 into curse of mirra's front

Summary of changes

  • Implemented items mechanics
  • Added new item Fake Item
  • Added Arena.Game.Item and Arena.Game.Trap modules
  • Added Trap and TrapStatus message to messages.proto

Demo

Screen.Recording.2024-05-14.at.17.31.54.mov

How to test it?

You'll see that now an item could've this fields. Traps are entities too, so they pretty much will have the same parameters as any other entity. In the code you'll which fields are part of the additional info

  {
    "name": "fake_item",
    "radius": 200.0,
    "effects": [],
    "mechanics": {
      "spawn_bomb": {
        "name": "bomb",
        "radius": 200.0,
        "activation_delay_ms": 3000,
        "vertices": [],
        "mechanics": {
          "circle_hit": {
            "damage": 64,
            "range": 380.0,
            "offset": 400
          }
        }
      }
    }

They're pretty much self explanatory, but maybe we should add a field that addresses animation time.

  • Get a Fake Item
  • Use it nearby an enemy and it will leave a bomb
  • Wait until explodes
  • Boom!

Checklist

  • Tested the changes locally.
  • Reviewed the changes on GitHub, line by line.
  • This change requires new documentation.
    • Documentation has been added/updated.

@tvillegas98 tvillegas98 changed the title Gh 580 fake item [GH-580] - Fake Item May 10, 2024
@manucamejo manucamejo changed the title [GH-580] - Fake Item [GH-580] Fake Item May 10, 2024
@lotuuu lotuuu added the champions MOBA game label May 13, 2024
@tvillegas98 tvillegas98 changed the title [GH-580] Fake Item [GH-580] Fake Item and Traps May 14, 2024
Copy link
Contributor

@agustinesco agustinesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After talking with @manucamejo we should change the behavior from a bomb to a landmine

@tvillegas98
Copy link
Contributor Author

After talking with @manucamejo we should change the behavior from a bomb to a landmine

Addressed !

Copy link
Contributor

@agustinesco agustinesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add a time of preparation or something like that because i think when you use the fake item the explosion is being triggered instantaneously

@tvillegas98
Copy link
Contributor Author

Maybe we should add a time of preparation or something like that because i think when you use the fake item the explosion is being triggered instantaneously

Done

agustinesco
agustinesco previously approved these changes May 17, 2024
Copy link
Contributor

@agustinesco agustinesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! the game client is broken tho, it is not displaying the crates and traps correctly, let's adress this in another pr

Copy link
Collaborator

@Nico-Sanchez Nico-Sanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some PR to test this?
Either work on the client app or make a PR in unity repo. It's really hard to test its behavior when I cannot see the dropped item.

@tvillegas98
Copy link
Contributor Author

Can we add some PR to test this? Either work on the client app or make a PR in unity repo. It's really hard to test its behavior when I cannot see the dropped item.

They should be visible now!

Copy link
Collaborator

@Nico-Sanchez Nico-Sanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @tvillegas98 🚀

Here's a video as a proof of this new item and trap behavior:

  • The purple dot in browser is the fake item trap.
Untitled.mov

apps/arena/priv/config.json Outdated Show resolved Hide resolved
Copy link
Contributor

@agustinesco agustinesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agustinesco agustinesco merged commit 3b330bc into main May 20, 2024
1 check passed
@agustinesco agustinesco deleted the gh-580-fake-item branch May 20, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
champions MOBA game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Fake item and Traps base
5 participants