-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-580] Fake Item and Traps #598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After talking with @manucamejo we should change the behavior from a bomb to a landmine
Addressed ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should add a time of preparation or something like that because i think when you use the fake item the explosion is being triggered instantaneously
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! the game client is broken tho, it is not displaying the crates and traps correctly, let's adress this in another pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some PR to test this?
Either work on the client app or make a PR in unity repo. It's really hard to test its behavior when I cannot see the dropped item.
They should be visible now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job @tvillegas98 🚀
Here's a video as a proof of this new item and trap behavior:
- The purple dot in browser is the fake item trap.
Untitled.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Motivation
Add the new fake item to the game and also add the new traps feature.
Closes #580
After merging this, lets merge https://github.com/lambdaclass/curse_of_mirra/pull/1772 into curse of mirra's front
Summary of changes
Fake Item
Arena.Game.Item
andArena.Game.Trap
modulesTrap
andTrapStatus
message tomessages.proto
Demo
Screen.Recording.2024-05-14.at.17.31.54.mov
How to test it?
You'll see that now an item could've this fields. Traps are entities too, so they pretty much will have the same parameters as any other entity. In the code you'll which fields are part of the additional info
They're pretty much self explanatory, but maybe we should add a field that addresses animation time.
Checklist