Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-581] Implement daily quest feature #590
[GH-581] Implement daily quest feature #590
Changes from all commits
b77f9e9
4089830
17c42bc
d9661ed
99321c4
66134c6
80a0ebd
55e634c
ca522ee
89f1963
7ef676b
8789541
1d8e2e8
d69c1aa
de61842
b978c12
2e8c6c7
03c611e
ab2c652
91f92ae
fd2ead7
3781881
a2a3a6c
98b9921
872ac61
29f791d
656d568
e815671
9fc7adc
8160451
ce9db3b
d4b8d3b
d6a3be4
5c460fb
ff9fda3
703677e
69bab8b
74e3cd5
370ea37
889aa6b
fcbeec2
79b08f1
8003548
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you feel curious you can try the actual Ecto Upsert rather than implement your own, but full disclosure I have never used it so no idea if it will work, but would be a nice improvement here if it does
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm if we use the Ecto upsert we should update every other upsert already implemented in the repo, maybe we could do this change in a proper pr