Dynamic execution duration for leap #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AminArria
force-pushed
the
leap-dynamic-duration
branch
from
fb1646a to
64d3dfa
Compare
manucamejo
previously requested changes
Mar 21, 2024
apps/arena/lib/arena/game/player.ex
Outdated
| ## so to simplify my life an executive decision was made to take thas as a fact | ||
| ## When the time comes to have more than one mechanic per skill this function will need to be refactored, good thing | ||
| ## is that it will crash here so not something we can ignore | ||
| defp calculate_duration(%{mechanics: [%{leap: leap}]}, position, direction) do |
There was a problem hiding this comment.
This is not working. It should be:
defp calculate_duration(%{mechanics: [leap: leap]}, position, direction) do
AminArria
force-pushed
the
leap-dynamic-duration
branch
from
98a05ff to
ca09cde
Compare
AminArria
changed the title
agustinesco
reviewed
May 9, 2024
agustinesco
reviewed
May 9, 2024
agustinesco
reviewed
May 9, 2024
agustinesco
reviewed
May 9, 2024
agustinesco
requested changes
May 9, 2024
agustinesco
requested changes
May 10, 2024
manucamejo
approved these changes
May 13, 2024
agustinesco
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes leap from having a fixed duration and dynamic speed to having fixed speed and dynamic duration