Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more time for SocketTester messages in tests #364

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

lotuuu
Copy link
Contributor

@lotuuu lotuuu commented Mar 12, 2024

Closes https://github.com/orgs/lambdaclass/projects/18/views/7?pane=issue&itemId=56588663

Some of the Champions tests are occasionally failing because messages sometimes failed to be sent in time. For example: https://github.com/lambdaclass/mirra_backend/actions/runs/8252380274/job/22571736812. This PR doubles the timeout value to avoid this.

@lotuuu lotuuu changed the title Allow more time for SocketTester messages Allow more time for SocketTester messages in tests Mar 12, 2024
@lotuuu lotuuu self-assigned this Mar 13, 2024
Copy link
Contributor

@agustinesco agustinesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ncontinanza ncontinanza merged commit 9a22bd6 into main Mar 19, 2024
1 check passed
@ncontinanza ncontinanza deleted the add-more-time-for-messages-tests branch March 19, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants