[GH-309] add valtimer teleport #305
Conversation
apps/arena/lib/arena/game/skill.ex
Outdated
| player | ||
| |> Physics.move_entity_to_position(target_position, game_state.external_wall) | ||
| |> Map.put(:aditional_info, player.aditional_info) | ||
| |> maybe_make_invinsible(teleport) |
There was a problem hiding this comment.
Just to make sure I understand, they idea is to give you 300 ms (current config) of damage immunity after you teleport?
There was a problem hiding this comment.
no, te idea is to give inmunity while you're teleporting, also we should adjust the time of the inmunity later on when we have something solid in the client
There was a problem hiding this comment.
Then why do you need the immunity? Teleportation is instant, how could someone damage you while teleporting?
There was a problem hiding this comment.
That's a hacky solution for how the teleport will be represented in the front, they will make the character model to go under the floor, walk down there and then get up on the final destinations. Thinking about it, maybe we don't even need a new case for do_mechanic because we could simply make it a dash and call it a teleport, the thing is that the character won't be visible, so the invisibility is needed
There was a problem hiding this comment.
JAJAJAJA that explains it
🤔 mmm honestly don't like any of those hacks... would it be possible for them to dissapear and appear the model? We could, in theory, remove the player from game_state.players and bring it back say 30 ms laters (or whatever we configure), essentially disappear the player for some time
There was a problem hiding this comment.
hmmm i'm not entirelly sure, maybe we could talk with @saugon about this
| { | ||
| "teleport": { | ||
| "range": 1000, | ||
| "duration_ms": 300 |
There was a problem hiding this comment.
I think we should include the radius of the ability so we can displayed it in the client. Or maybe we can use the hitbox radius in the client to display it.
What do you think?
There was a problem hiding this comment.
hmmm i think the radius and the range are the same in the context of the teleport, we could simply rename this
There was a problem hiding this comment.
I do not think that is gonna work because we use the range and area to draw different indicators in the client. I mean with the range we draw the outer circle area and with the radius the inner circle area.
What I suggest is that maybe we can use the hitbox of the character to display the inner area since it indicates where the character body is gonna be placed. WDYT?
There was a problem hiding this comment.
ooooh right! yeah we should use the body size for the inner circle indicator
mgrunwaldt
temporarily deployed
to
testing-brazil
GitHub Actions
Inactive
apps/arena/lib/arena/game/player.ex
Outdated
| @@ -362,4 +382,16 @@ defmodule Arena.Game.Player do | |||
| player | |||
| end | |||
| end | |||
|
|
|||
| defp maybe_make_invinsible( | |||
There was a problem hiding this comment.
Why "invisible" instead of "invulnerable"?
There was a problem hiding this comment.
it was the name given by the item implementation, i just s̶t̶o̶l̶e̶ use that in this case
There was a problem hiding this comment.
Oh, I just realized it says "invinsible", not "invisible" as in not visible. There's a typo there though, it should be "invincible"!
There was a problem hiding this comment.
right! i didn't noticed it either lol fixed!
apps/arena/lib/arena/game/player.ex
Outdated
| @@ -362,4 +382,16 @@ defmodule Arena.Game.Player do | |||
| player | |||
| end | |||
| end | |||
|
|
|||
| defp maybe_make_invinsible( | |||
There was a problem hiding this comment.
Oh, I just realized it says "invinsible", not "invisible" as in not visible. There's a typo there though, it should be "invincible"!
agustinesco
had a problem deploying
to
testing-brazil
GitHub Actions
Failure
agustinesco
had a problem deploying
to
testing-brazil
GitHub Actions
Failure
agustinesco
temporarily deployed
to
testing-brazil
GitHub Actions
Inactive
agustinesco
had a problem deploying
to
testing-europe
GitHub Actions
Failure
agustinesco
temporarily deployed
to
testing-brazil
GitHub Actions
Inactive
samoht9277
had a problem deploying
to
testing-europe
GitHub Actions
Failure
| action_name = skill_key_execution_action(skill_key) | ||
| action = | ||
| %{ | ||
| action: skill_key_execution_action(skill_key), |
There was a problem hiding this comment.
Do you think action_name would be a better name here? At first sight it looks like action contains an action, as a sort of compound entity, which is not what you're trying to represent here.
There was a problem hiding this comment.
yeah that makes sense , so we can avoid this abomination action.action
There was a problem hiding this comment.
actually i think this is a bigger change than just renaming this, because we need to change the player action everywhere. This change was only something to avoid adding multiple parameters to the add_action function, if you think this make things worse we can revert it
There was a problem hiding this comment.
Oh, let's leave it like this then
Closes #309
Implement teleport mechanic
The teleport mechanic will move the player in the same instant when it's executed, the player should not be vulnerable while this is occurring
Testing
to test this pr play a match with valtimer with this client branch and use the teleport ability, you can also go to this link and press the "P" key