Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead players doing damage #1009

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Nico-Sanchez
Copy link
Collaborator

@Nico-Sanchez Nico-Sanchez commented Dec 13, 2024

Motivation

Players were doing damage even after death.
Closes #551

Summary of changes

How to test it?

Play a game and execute skills when about to die. Everything but player mechanics (proyectiles, pools) should still work, but not the players' mechanics (circle_hit, etc).

Here's a video with the fix:

Uploading Screen Recording 2024-12-12 at 6.41.51 PM.mov…

Checklist

  • Tested the changes locally.
  • Reviewed the changes on GitHub, line by line.
  • This change requires new documentation.
    • Documentation has been added/updated.

@Nico-Sanchez Nico-Sanchez force-pushed the fix-dead-players-doing-damage branch from 2384d45 to e3ffae0 Compare December 13, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Do not trigger melee skill action (dmg, etc) if owner is dead
2 participants