Unblock player action inputs when dash/leap are finished (#995)

Co-authored-by: Manuel Camejo <[email protected]>

apps/arena/lib/arena/game/player.ex

@@ -235,7 +235,13 @@ defmodule Arena.Game.Player do
           end
 
         execution_duration = calculate_duration(skill, player.position, skill_direction, auto_aim?)
-        Process.send_after(self(), {:block_actions, player.id, false}, execution_duration)
+
+        # For dash and leaps, we rely the unblock action message to their stop action callbacks
+        is_dash_or_leap? = Enum.any?(skill.mechanics, fn mechanic -> mechanic.type in ["leap", "dash"] end)
+
+        unless is_dash_or_leap? do
+          Process.send_after(self(), {:block_actions, player.id, false}, execution_duration)
+        end
 
         if skill.block_movement do
           send(self(), {:block_movement, player.id, true})

apps/arena/lib/arena/game_updater.ex

@@ -409,6 +409,9 @@ defmodule Arena.GameUpdater do
       Map.get(state.game_state.players, player_id)
       |> Player.reset_forced_movement(previous_speed)
 
+    # Dash finished, we unblock the actions.
+    broadcast_player_block_actions(state.game_state.game_id, player_id, false)
+
     state = put_in(state, [:game_state, :players, player_id], player)
     {:noreply, state}
   end
@@ -422,6 +425,9 @@ defmodule Arena.GameUpdater do
       put_in(state.game_state, [:players, player_id], player)
       |> Skill.do_mechanic(player, on_arrival_mechanic, %{skill_direction: player.direction})
 
+    # Leap finished, we unblock the actions.
+    broadcast_player_block_actions(state.game_state.game_id, player_id, false)
+
     {:noreply, %{state | game_state: game_state}}
   end