Optimize bls12 381 pairing #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #923 +/- ##
==========================================
+ Coverage 70.96% 71.08% +0.11%
==========================================
Files 144 144
Lines 31672 31824 +152
==========================================
+ Hits 22477 22622 +145
- Misses 9195 9202 +7 ☔ View full report in Codecov by Sentry. |
Oppen
reviewed
Oct 3, 2024
Comment on lines
120
to
157
| pub fn miller( | ||
| q: &ShortWeierstrassProjectivePoint<BLS12381TwistCurve>, | ||
| p: &ShortWeierstrassProjectivePoint<BLS12381Curve>, | ||
| ) -> FieldElement<Degree12ExtensionField> { | ||
| let mut r = q.clone(); | ||
| let mut f = FieldElement::<Degree12ExtensionField>::one(); | ||
| let mut miller_loop_constant = MILLER_LOOP_CONSTANT; | ||
| let mut miller_loop_constant_bits: alloc::vec::Vec<bool> = alloc::vec![]; | ||
|
|
||
| while miller_loop_constant > 0 { | ||
| miller_loop_constant_bits.insert(0, (miller_loop_constant & 1) == 1); | ||
| miller_loop_constant >>= 1; | ||
| } | ||
|
|
||
| for bit in miller_loop_constant_bits[1..].iter() { | ||
| double_accumulate_line(&mut r, p, &mut f); | ||
| if *bit { | ||
| add_accumulate_line(&mut r, q, p, &mut f); | ||
| } | ||
| } | ||
| f.conjugate() | ||
| } | ||
| #[allow(unused)] | ||
| pub fn miller_optimized( | ||
| q: &ShortWeierstrassProjectivePoint<BLS12381TwistCurve>, | ||
| p: &ShortWeierstrassProjectivePoint<BLS12381Curve>, | ||
| ) -> FieldElement<Degree12ExtensionField> { | ||
| let mut r = q.clone(); | ||
| let mut f = FieldElement::<Degree12ExtensionField>::one(); | ||
| X_BINARY.iter().skip(1).for_each(|bit| { | ||
| double_accumulate_line(&mut r, p, &mut f); | ||
| if *bit { | ||
| add_accumulate_line(&mut r, q, p, &mut f); | ||
| } | ||
| }); | ||
|
|
||
| f.conjugate() | ||
| } |
There was a problem hiding this comment.
Maybe we can just keep miller_optimized as miller and, if we need the old one for validation, call it miller_slow.
Oppen
reviewed
Oct 3, 2024
| fn miller( | ||
| q: &ShortWeierstrassProjectivePoint<BLS12381TwistCurve>, | ||
| p: &ShortWeierstrassProjectivePoint<BLS12381Curve>, | ||
| pub fn final_exponentiation( |
There was a problem hiding this comment.
Similarly, if both implementations are essentially the same in intent, reserve the plain name for the fast version.
diegokingston
approved these changes
Oct 4, 2024
Oppen
reviewed
Oct 4, 2024
Comment on lines
101
to
104
| // Miller | ||
| group.bench_function("Miller Naive", |bencher| { | ||
| bencher.iter(|| black_box(miller(black_box(&a_g2), black_box(&a_g1)))) | ||
| }); |
There was a problem hiding this comment.
I believe this is no longer the naive version.
Oppen
reviewed
Oct 4, 2024
| } | ||
|
|
||
| #[allow(clippy::needless_range_loop)] |
Oppen
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BLS 12-381 pairing optimization
Description
This PR aims to improve the pairing for the bls 12-381 curve by using optimized operations
Type of change
Benches
Actual
Ate pairing: 12.169 msFinal exponentiation: 11.499 msNew version
Ate pairing: 2.0644 msFinal exponentiation: 1.0674 ms