Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Mersenne31 Field #921

Merged
merged 38 commits into from
Oct 1, 2024
Merged

Optimize Mersenne31 Field #921

merged 38 commits into from
Oct 1, 2024

Conversation

nicole-graus
Copy link
Contributor

@nicole-graus nicole-graus commented Sep 27, 2024

Optimize Mersenne31 Field

Description

In this PR we improve the Mersenne31 field operations and add the extensions of degree 2 and 4.

Type of change

Please delete options that are not relevant.

  • Optimization

@nicole-graus nicole-graus requested a review from a team as a code owner September 27, 2024 14:17
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 90.03497% with 57 lines in your changes missing coverage. Please review.

Project coverage is 70.95%. Comparing base (9617e52) to head (b6165b3).

Files with missing lines Patch % Lines
math/src/field/fields/mersenne31/extensions.rs 88.04% 52 Missing ⚠️
math/src/unsigned_integer/element.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #921      +/-   ##
==========================================
+ Coverage   70.75%   70.95%   +0.19%     
==========================================
  Files         143      143              
  Lines       30985    31284     +299     
==========================================
+ Hits        21923    22197     +274     
- Misses       9062     9087      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@diegokingston diegokingston added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 7a427aa Oct 1, 2024
8 checks passed
@diegokingston diegokingston deleted the optimize_mersenne31 branch October 1, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants