Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Field): Add mersenne31 #669

Merged
merged 28 commits into from
Nov 16, 2023
Merged

Conversation

PatStiles
Copy link
Collaborator

Add Mersenne31

Description

Reopens #623

Type of change

Please delete options that are not relevant.

  • New feature

@PatStiles PatStiles requested review from schouhy, ajgara and a team as code owners November 6, 2023 18:24
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2023

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (08e9444) 96.70% compared to head (4e9f9cc) 96.57%.

Files Patch % Lines
math/src/field/fields/mersenne31/extension.rs 83.95% 30 Missing ⚠️
...elds/fft_friendly/u64_mersenne_montgomery_field.rs 0.00% 15 Missing ⚠️
math/src/field/fields/mersenne31/field.rs 96.51% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
- Coverage   96.70%   96.57%   -0.14%     
==========================================
  Files         124      127       +3     
  Lines       28782    29271     +489     
==========================================
+ Hits        27835    28268     +433     
- Misses        947     1003      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

entropidelic and others added 3 commits November 7, 2023 00:24
* Add docs for stone prover trace with plain layout

* Add csv traces of fibonacci program

* Add stone prover docs to mdbook
@entropidelic entropidelic added this pull request to the merge queue Nov 16, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 16, 2023
@entropidelic entropidelic added this pull request to the merge queue Nov 16, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 16, 2023
@entropidelic entropidelic added this pull request to the merge queue Nov 16, 2023
Merged via the queue into lambdaclass:main with commit 7cde35f Nov 16, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants