-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate cli to extern crate #598
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #598 +/- ##
==========================================
+ Coverage 95.61% 95.71% +0.09%
==========================================
Files 111 111
Lines 19318 19298 -20
==========================================
Hits 18471 18471
+ Misses 847 827 -20
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
4 tasks
diegokingston
approved these changes
Oct 11, 2023
The PR looks good! nice work.
|
MauroToscano
approved these changes
Oct 12, 2023
Lets merge this now and update the readme with CLI usage instructions in another PR |
entropidelic
approved these changes
Oct 12, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAIRO PROVER CLI
Description
Migration of cli functionallity to an external crate that uses clap4 for argument parsing and handling.
cairo-prover
as a pure lib, and thecairo-prover-cli
as a pure app.Type of change
Checklist