Stark: Stone prover compatibility end to end for Fibonacci AIR #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schouhy
changed the title
provers/stark/src/prover.rs
Outdated
Comment on lines
931
to
934
| pub struct Prover; | ||
|
|
||
| impl IsStarkProver for Prover { | ||
| type Field = Stark252PrimeField; |
There was a problem hiding this comment.
It would be better for this type definition to be on top of the file, before the function, so it doesn't get lost
3 tasks
Comment on lines
+111
to
+112
| let commitment = tree.root; | ||
| (tree, commitment) |
There was a problem hiding this comment.
maybe I'm missing some detail, but couldn't we just return the tree directly and use tree.root outside the function when needed?
There was a problem hiding this comment.
Ah, we can do that. But we lose the semantics of that function, because we wouldn't be commiting anymore, just building a merkle tree. We would have to rename it.
There was a problem hiding this comment.
ok maybe not too important for now, lets leave it like this
There was a problem hiding this comment.
Name is tricky, it's doing a commitment and returning the tree for further use
MauroToscano
approved these changes
Oct 17, 2023
diegokingston
approved these changes
Oct 17, 2023
| .zip(evaluation_point_inverse) | ||
| .enumerate() | ||
| .fold(true, |mut result, (i, ((proof_s, iota_s), eval))| { | ||
| // this is done in constant time |
There was a problem hiding this comment.
This constant time comment, I'm not sure if it's useful
entropidelic
approved these changes
Oct 17, 2023
PatStiles
pushed a commit
to PatStiles/lambdaworks
that referenced
this pull request
Oct 18, 2023
…aclass#596) * add test * make trace commitment SHARP compatible * wip * use powers of a single challenge for the boundary and transition coefficients * add permutation to match sharp compatible commitments on the trace * change trait bound from ByteConversion to Serializable * minor refactor * fmt, clippy * move std feature to inner trait function in Serializable * add IsStarkProver and IsStarkVerifier traits * proof of concept * composition poly breaker * WIP: commitment composition poly works. Opens are broken. * WIP Refactor open_trace_polys and open_composition_poly * Refactor sample iotas * Refactor sample iotas * make fri a trait * change trace ood evaluations in transcript * wip * sample gammas as power of a single challenge * fix z fri sampling * wip * wip * wip, broken * Compiles but fibonacci_5 does not work * Opens of query phase and OOD broken. Commit phase of FRI works. * Dont append to the transcript when grinding factor is zero * skip grinding factor when security bits is zero * remove permutation function * fmt * fix standard verifier * removes deep consistency check and openings of the first layer of fri for each query * SHARP computes the trace and composition polynomial openings and their symmetric elements consistently * Test symmetric elements in trace openings to compute deep composition polynomial * Composition polynomial opening evaluations are splitted between symmetric and not. The authentication paths remain equal * check openings in symmetric elements * make verifier sharp compatible * compute number of parts * fix verify fri for original prover * fix verify sym in stone prover * rename * rename file * wip * remove unnecessary variable * wip * move verifier * move fri * fix open * move stone to prover * remove file * fmt * clippy * clippy * remove redundant trait bounds * remove custom serialization/deserialization and replace it with serde_cbor * fmt * clippy * remove old files after merge from main * fmt * make field a type of IsStarkVerifier * remove frame serialization * separate compatibility test into individual tests * remove redundant test * add test case 2 * minor refactor. add docs * minor refactor * remove unnecessary method * revert unintended changes to exercises * clippy * remove isFri trait * move Prover definition to the top of the file * update docs and add unit test * minor refactors. clippy * remove unused trait method * Move function only used for tests, to tests --------- Co-authored-by: Agustin <[email protected]> Co-authored-by: MauroFab <[email protected]>
PatStiles
pushed a commit
to PatStiles/lambdaworks
that referenced
this pull request
Oct 20, 2023
…aclass#596) * add test * make trace commitment SHARP compatible * wip * use powers of a single challenge for the boundary and transition coefficients * add permutation to match sharp compatible commitments on the trace * change trait bound from ByteConversion to Serializable * minor refactor * fmt, clippy * move std feature to inner trait function in Serializable * add IsStarkProver and IsStarkVerifier traits * proof of concept * composition poly breaker * WIP: commitment composition poly works. Opens are broken. * WIP Refactor open_trace_polys and open_composition_poly * Refactor sample iotas * Refactor sample iotas * make fri a trait * change trace ood evaluations in transcript * wip * sample gammas as power of a single challenge * fix z fri sampling * wip * wip * wip, broken * Compiles but fibonacci_5 does not work * Opens of query phase and OOD broken. Commit phase of FRI works. * Dont append to the transcript when grinding factor is zero * skip grinding factor when security bits is zero * remove permutation function * fmt * fix standard verifier * removes deep consistency check and openings of the first layer of fri for each query * SHARP computes the trace and composition polynomial openings and their symmetric elements consistently * Test symmetric elements in trace openings to compute deep composition polynomial * Composition polynomial opening evaluations are splitted between symmetric and not. The authentication paths remain equal * check openings in symmetric elements * make verifier sharp compatible * compute number of parts * fix verify fri for original prover * fix verify sym in stone prover * rename * rename file * wip * remove unnecessary variable * wip * move verifier * move fri * fix open * move stone to prover * remove file * fmt * clippy * clippy * remove redundant trait bounds * remove custom serialization/deserialization and replace it with serde_cbor * fmt * clippy * remove old files after merge from main * fmt * make field a type of IsStarkVerifier * remove frame serialization * separate compatibility test into individual tests * remove redundant test * add test case 2 * minor refactor. add docs * minor refactor * remove unnecessary method * revert unintended changes to exercises * clippy * remove isFri trait * move Prover definition to the top of the file * update docs and add unit test * minor refactors. clippy * remove unused trait method * Move function only used for tests, to tests --------- Co-authored-by: Agustin <[email protected]> Co-authored-by: MauroFab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stark: Stone prover compatibility end to end for Fibonacci AIR
Description
This PR implements the same Merkle tree and FRI logic to obtain the same exact results as the Stone prover for the Fibonacci AIR for a single FRI query and no grinding factor. The source of the test cases can be found here.
Support for multiple queries, grinding factor and docs will be added in subsequent PRs.