Stark: Small refactor of StarkTranscript #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajgara
approved these changes
Sep 25, 2023
Codecov Report
@@ Coverage Diff @@
## main #574 +/- ##
==========================================
- Coverage 95.50% 95.50% -0.01%
==========================================
Files 112 112
Lines 19006 19003 -3
==========================================
- Hits 18152 18149 -3
Misses 854 854
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
MauroToscano
approved these changes
Sep 25, 2023
diegokingston
approved these changes
Sep 25, 2023
PatStiles
pushed a commit
to PatStiles/lambdaworks
that referenced
this pull request
Sep 26, 2023
* small refactor of starkprovertranscript * move keccak_hash to StarkProverTranscript impl
PatStiles
pushed a commit
to PatStiles/lambdaworks
that referenced
this pull request
Oct 6, 2023
* small refactor of starkprovertranscript * move keccak_hash to StarkProverTranscript impl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactor of StarkTranscript
Description
This PR does as small reorganization of the code of
stark/src/transcript.rsaddssample_z_oodto theStarkTranscripttrait. It also moves constants only used byStoneProverTranscriptto its implementation. And replaces thehasherattribute by astate.