-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stark: make transcript compatible with Stone Prover #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schouhy
force-pushed
the
transcript-compatibility
branch
from
September 21, 2023 14:38
e6005d8
to
6e4c8bc
Compare
Codecov Report
@@ Coverage Diff @@
## main #570 +/- ##
==========================================
+ Coverage 95.46% 95.50% +0.04%
==========================================
Files 112 112
Lines 18811 19005 +194
==========================================
+ Hits 17957 18151 +194
Misses 854 854
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…bdaworks into transcript-compatibility
diegokingston
approved these changes
Sep 22, 2023
MauroToscano
approved these changes
Sep 22, 2023
schouhy
force-pushed
the
transcript-compatibility
branch
from
September 22, 2023 18:14
74e9d48
to
fc906d7
Compare
ajgara
approved these changes
Sep 22, 2023
PatStiles
pushed a commit
to PatStiles/lambdaworks
that referenced
this pull request
Sep 26, 2023
* add StarkTranscript trait and implementation * make append field element compatible with stone prover * add test * add tests * uncomment test * remove code added by mistake to exercises * make counter of type u32
PatStiles
pushed a commit
to PatStiles/lambdaworks
that referenced
this pull request
Oct 6, 2023
* add StarkTranscript trait and implementation * make append field element compatible with stone prover * add test * add tests * uncomment test * remove code added by mistake to exercises * make counter of type u32
PatStiles
pushed a commit
to PatStiles/lambdaworks
that referenced
this pull request
Oct 21, 2023
* add StarkTranscript trait and implementation * make append field element compatible with stone prover * add test * add tests * uncomment test * remove code added by mistake to exercises * make counter of type u32
PatStiles
pushed a commit
to PatStiles/lambdaworks
that referenced
this pull request
Nov 6, 2023
* add StarkTranscript trait and implementation * make append field element compatible with stone prover * add test * add tests * uncomment test * remove code added by mistake to exercises * make counter of type u32
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
* add mersenne31 prime field * fix representative field all tests passing * delete cmt * add bench for U64 mont and mersenne31 * Stark: make transcript compatible with Stone Prover (#570) * add StarkTranscript trait and implementation * make append field element compatible with stone prover * add test * add tests * uncomment test * remove code added by mistake to exercises * make counter of type u32 * add field extension and fuzz * clean up and add improved add and sub * update inv() fuzz working * plonky3 fuzz target * fix ci * fix lint attempt 2 * fix comment * add no std features for Mersenne31 ByteConversion * fix ci * fix comment * add bench * add mersenne montgomery bench * fmt * fix old merge conflcit * fix bench method * docs: stone prover trace docs - layout plain (#658) * Add docs for stone prover trace with plain layout * Add csv traces of fibonacci program * Add stone prover docs to mdbook * fix ci * Fix name in clippy lints --------- Co-authored-by: Sergio Chouhy <[email protected]> Co-authored-by: Mariano A. Nicolini <[email protected]> Co-authored-by: Mauro Toscano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make transcript compatible with Stone Prover
Description
This PR implements the transcript strategy used in the Stone Prover. Unit tests are added for sampling field elements, bytes and
u64
off the transcript. Here is the source of those tests. Also integration tests are added by following all annotations in the Stone Prover in small Fibonacci examples.Description of the pull request changes and motivation.
Type of change
Checklist