Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pub keyword to poseidon hash function #569

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

mdvillagra
Copy link
Contributor

Add pub keyword to poseidon hash function

Description

Add a pub keyworkd to the function hash of the Poseidon struct. This will allow to use the function for hashing when adding the lambdaworks-crypto package.

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization

Checklist

  • Linked to Github Issue
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run

@mdvillagra mdvillagra requested review from schouhy, ajgara and a team as code owners September 21, 2023 01:30
@codecov-commenter
Copy link

Codecov Report

Merging #569 (3f1ef7e) into main (a190b17) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #569   +/-   ##
=======================================
  Coverage   95.50%   95.50%           
=======================================
  Files         112      112           
  Lines       18904    18904           
=======================================
  Hits        18054    18054           
  Misses        850      850           
Files Changed Coverage Δ
crypto/src/hash/poseidon/mod.rs 90.47% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MauroToscano MauroToscano added this pull request to the merge queue Sep 22, 2023
Merged via the queue into lambdaclass:main with commit 976c237 Sep 22, 2023
@mdvillagra mdvillagra deleted the pub-poseidon branch September 22, 2023 16:44
PatStiles pushed a commit to PatStiles/lambdaworks that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants