Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stark: Remove degree adjustment from composition poly #563

Merged
merged 9 commits into from
Sep 21, 2023

Conversation

schouhy
Copy link
Contributor

@schouhy schouhy commented Sep 19, 2023

Remove degree adjustment from composition poly

Description

This PR removes the degree adjustment from the composition polynomial for compatibility with the stone prover.

@schouhy schouhy requested review from ajgara and a team as code owners September 19, 2023 20:48
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Merging #563 (2fdd56e) into main (1da50bc) will decrease coverage by 0.05%.
The diff coverage is 96.66%.

@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
- Coverage   95.50%   95.46%   -0.05%     
==========================================
  Files         112      112              
  Lines       18904    18811      -93     
==========================================
- Hits        18054    17957      -97     
- Misses        850      854       +4     
Files Changed Coverage Δ
provers/stark/src/constraints/evaluator.rs 93.30% <91.66%> (-0.13%) ⬇️
provers/stark/src/prover.rs 99.86% <100.00%> (-0.01%) ⬇️
provers/stark/src/verifier.rs 98.88% <100.00%> (-0.08%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@MauroToscano MauroToscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should we update documentation @schouhy

@MauroToscano MauroToscano added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit 21cc017 Sep 21, 2023
@MauroToscano MauroToscano deleted the remove-degree-adjustment branch September 21, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants