Fix fuzzers (#564)

* Rust cache on check

* Fix fuzzer not building

* Move deserialize fuzzer to no gpu fuzzers

* Move deserialize fuzzer to no gpu fuzzers

* Remove duplicated fuzzer

* Update fuzzer makefile and readme

.gitignore

@@ -1,6 +1,6 @@
 # Generated by Cargo
 # will have compiled files and executables
-/target/
+**/target/**
 
 # Remove Cargo.lock from gitignore if creating an executable, leave it for libraries
 # More information here https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html
@@ -21,3 +21,5 @@ proving_system/stark/src/cairo_run/program.trace
 **/.DS_Store
 
 ensure-no_std/target
+# Files from fuzzers are inside a corpus folder
+**/corpus/**

Makefile

@@ -1,5 +1,7 @@
 .PHONY: test clippy docker-shell nix-shell benchmarks benchmark docs build-cuda build-metal clippy-metal test-metal coverage clean
 
+FUZZ_DIR = fuzz/no_gpu_fuzz
+
 ROOT_DIR:=$(shell dirname $(realpath $(firstword $(MAKEFILE_LIST))))
 
 CAIRO0_PROGRAMS_DIR=provers/cairo/cairo_programs/cairo0
@@ -76,22 +78,16 @@ build-cuda:
 docs:
 	cd docs && mdbook serve --open
 
-STARK_DESERIALIZE_FUZZER = deserialize_stark_proof
+run-fuzzer:
+		cargo +nightly fuzz run --fuzz-dir $(FUZZ_DIR) $(FUZZER)
+
 proof-deserializer-fuzzer:
-		cd fuzz/deserialize_stark_proof
-		cargo +nightly fuzz run --fuzz-dir . $(STARK_DESERIALIZE_FUZZER)
+		cargo +nightly fuzz run --fuzz-dir $(FUZZ_DIR)  deserialize_stark_proof
 
-FUZZER = field_from_hex
-run-no-gpu-fuzzer:
-		cd fuzz/no_gpu_fuzz
-		cargo +nightly fuzz run --fuzz-dir . $(FUZZER)
-
-METALFUZZER = fft_diff
 run-metal-fuzzer:
 		cd fuzz/metal_fuzz
-		cargo +nightly fuzz run --fuzz-dir . $(METALFUZZER)
+		cargo +nightly fuzz run --fuzz-dir  $(FUZZ_DIR) fft_diff
 
-CUDAFUZZER = cuda_fft_fuzzer
 run-cuda-fuzzer:
 		cd fuzz/cuda_fuzz
 		cargo hfuzz run $(CUDAFUZZER)

README.md

@@ -56,6 +56,21 @@ If you use ```Lambdaworks``` libraries in your research projects, please cite th
 
 ## Fuzzers
 
+Fuzzers are divided between the ones that use only the CPU, the ones that use Metal, and the ones that use CUDA.
+
+CPU Fuzzers can be run with the command ```bash make run-fuzzer FUZZER=fuzzer_name```
+
+For example:
+
+```bash
+make run-fuzzer FUZZER=field_from_hex
+```
+
+The list of fuzzers can be found in `fuzz/no_gpu_fuzz`
+
+Fuzzers for FTT in Metal and Cuda can be run with `make run-metal-fuzzer` and `make run-cuda-fuzzer`
+
+
 Run a specific fuzzer from the ones contained in **fuzz/fuzz_targets/** folder with`cargo`, for example to run the one for the target `field_from_hex`:
 
 ```bash

fuzz/Cargo.toml

@@ -1,5 +1,6 @@
 [workspace]
 members = ["no_gpu_fuzz", "metal_fuzz", "cuda_fuzz"]
+resolver = "2"
 
 [workspace.package]
 edition = "2021"
@@ -9,6 +10,7 @@ version = "0.1.1"
 [workspace.dependencies]
 lambdaworks-math = { path = "../math" }
 lambdaworks-gpu = { path = "../gpu" }
+stark-platinum-prover = { path = "../provers/stark" }
 libfuzzer-sys = "0.4"
 
 [profile.release]

fuzz/no_gpu_fuzz/Cargo.toml

@@ -10,6 +10,8 @@ cargo-fuzz = true
 lambdaworks-math = { workspace = true }
 lambdaworks-gpu = { workspace = true }
 libfuzzer-sys = { workspace = true }
+stark-platinum-prover = { workspace = true }
+
 num-traits = "0.2"
 ibig = "0.3.6"
 
@@ -31,3 +33,10 @@ path = "fuzz_targets/field_from_raw.rs"
 test = false
 doc = false
 
+[[bin]]
+name = "deserialize_stark_proof"
+path = "fuzz_targets/deserialize_stark_proof.rs"
+test = false
+doc = false
+
+

fuzz/no_gpu_fuzz/fuzz_targets/deserialize_stark_proof.rs

@@ -0,0 +1,12 @@
+#![no_main]
+use libfuzzer_sys::fuzz_target;
+use stark_platinum_prover::proof::stark::StarkProof;
+use lambdaworks_math::field::fields::fft_friendly::stark_252_prime_field::Stark252PrimeField;
+use lambdaworks_math::traits::Deserializable;
+
+
+fuzz_target!(|data: Vec<u8>| {
+
+    let _proof = StarkProof::<Stark252PrimeField>::deserialize(&data);
+
+});