refactor: allow switching Store.blocks implementation
#676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpaulucci
reviewed
Jan 24, 2024
| @spec store_block(t(), Types.root(), SignedBeaconBlock.t()) :: t() | ||
| def store_block(%{inner: blocks} = state, block_root, signed_block) do | ||
| new_blocks = Map.put(blocks, block_root, signed_block) | ||
| %{state | inner: new_blocks} |
There was a problem hiding this comment.
I think we should find a different solution that doesn't store the blocks in store when they are in memory. There should be a common api to store blocks if it's on memory or on db, and they should not leak like in this case IMO.
There was a problem hiding this comment.
I understand that it is done like this to not break spec test, but there has to be a better way.
|
Closing this since we dropped support for in-memory storage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second version of #611