Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: base not found in tree #1318

Merged
merged 14 commits into from
Oct 7, 2024
Merged

fix: base not found in tree #1318

merged 14 commits into from
Oct 7, 2024

Conversation

rodrigo-o
Copy link
Collaborator

@rodrigo-o rodrigo-o commented Oct 3, 2024

Motivation

After a new finalized checkpoint we are having some issues related to base root not found in our fork choice tree (roots of blocks already recieved and showed as added in the logs)

Description
The issue that caused the base not found in the Fork choice tree was related to a bug in the PendingBlocks module. The bug made that when we had already processed a block, if some of its blobs are recieved later then the block is processed again, moved first to :pending (without checking its precvious status) and effectively being again the top of the fork choice. Then future blocks checked that their parents were downloaded (they were even processed) but none of them updated the head. At the moment of finalizing the tree the missing slots (the slot reprocessed +1 until the next epoch) are not part of the tree even if the state trantition moved on amd that caused the:
Parent 14C35B27D611342466C990ABE85147AFCDA13DBE2D5C05C4B3155309CF94FFFD not found in tree

To solve the issue a check was added at the time of blob processing, and just the blocks on :download_blobs status are taken into account.

Possible things to investigate further:

  • Why did the fork choice preferred the old block root as the head? shouldn't it prefer their children's? Reprocessing the same block shouldn't happen in the first place but in case of happening why did it re selected an old root as the head when the block was the same as before (not a reorg)

Note: I already merged both sync-issues-on-initial-node-run and current-slot-with-maximum-disparity to be in a better position regarding tests.

Resolves #1309

@rodrigo-o rodrigo-o marked this pull request as ready for review October 4, 2024 21:05
@rodrigo-o rodrigo-o requested a review from a team as a code owner October 4, 2024 21:05
Copy link
Collaborator

@Arkenan Arkenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rodrigo-o rodrigo-o enabled auto-merge (squash) October 7, 2024 20:34
@rodrigo-o rodrigo-o merged commit 3e7ce05 into main Oct 7, 2024
13 checks passed
@rodrigo-o rodrigo-o deleted the base-not-found-in-tree branch October 7, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Root not found in tree error hangs the node (Sepolia long run)
2 participants