-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: base not found in tree #1318
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…may fix the issue
Arkenan
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After a new finalized checkpoint we are having some issues related to base root not found in our fork choice tree (roots of blocks already recieved and showed as added in the logs)
Description
The issue that caused the base not found in the Fork choice tree was related to a bug in the PendingBlocks module. The bug made that when we had already processed a block, if some of its blobs are recieved later then the block is processed again, moved first to :pending (without checking its precvious status) and effectively being again the top of the fork choice. Then future blocks checked that their parents were downloaded (they were even processed) but none of them updated the head. At the moment of finalizing the tree the missing slots (the slot reprocessed +1 until the next epoch) are not part of the tree even if the state trantition moved on amd that caused the:
Parent 14C35B27D611342466C990ABE85147AFCDA13DBE2D5C05C4B3155309CF94FFFD not found in tree
To solve the issue a check was added at the time of blob processing, and just the blocks on
:download_blobs
status are taken into account.Possible things to investigate further:
Note: I already merged both
sync-issues-on-initial-node-run
andcurrent-slot-with-maximum-disparity
to be in a better position regarding tests.Resolves #1309