refactor: persist forkchoice state #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkenan
approved these changes
May 31, 2024
| @spec persist_store(Types.Store.t()) :: :ok | ||
| def persist_store(%Types.Store{} = store) do | ||
| put(@store_prefix, store) | ||
| end | ||
|
|
||
| @spec persist_fork_choice_store(Types.Store.t()) :: :ok |
There was a problem hiding this comment.
Why do we need a separate table? Is it not the same store we're saving?
There was a problem hiding this comment.
Merged into a single table!
| @@ -93,6 +95,7 @@ defmodule LambdaEthereumConsensus.ForkChoice do | |||
| prune_old_states(last_finalized_checkpoint.epoch, new_finalized_checkpoint.epoch) | |||
|
|
|||
| GenServer.cast(from, {:block_processed, block_root, true}) | |||
| persist_fork_choice_store(new_store) | |||
There was a problem hiding this comment.
I would persist before calling the cast. As a general rule it's useful that the state is stored and consistent before others are made aware of it. As a matter of fact, if we persist it before launching the recompute_head async task, we can remove the persist call in recompute-head.
There was a problem hiding this comment.
That's true. Done!
| @@ -219,4 +228,19 @@ defmodule LambdaEthereumConsensus.ForkChoice do | |||
| Logger.debug("[Fork choice] Store persisted") | |||
| end) | |||
| end | |||
|
|
|||
| defp persist_fork_choice_store(store) do | |||
| :telemetry.span([:fork_choice, :persist], %{}, fn -> | |||
There was a problem hiding this comment.
Let's have the telemetry call on the db methods directly, so they are called no matter who is storing/fetching the store.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to reduce complexity, we need to reduce concurrency as much as possible.
Description
This PR removes the use of the
GenServerstate, storing it into the db, taking the first step towards removing theGenServercalls.Additionally, it adds some metrics on store persisting and fetching:
Closes #1116
Closes #1117