feat(levm): add ethereum foundation tests

crates/vm/levm/Cargo.toml

@@ -13,6 +13,7 @@ serde_json = { version = "1.0.117" }
 walkdir = "2.5.0"
 ethereum_rust-rlp.workspace = true
 keccak-hash = "0.10.0"
+ethereum_rust-core.workspace = true
 
 [dev-dependencies]
 hex = "0.4.3"

crates/vm/levm/README.md

@@ -31,6 +31,11 @@ Features:
 [CallFrame](./docs/callframe.md)
 
 ### Testing
+
+#### Unit Testing
 To run the project's tests, do `make test`.
 
+#### EF Tests
+To run the EF Tests first download them from [here](https://github.com/ethereum/tests/tree/develop/GeneralStateTests). Then, inside the `tests` folder, create another folder named `ef_testcases` and include all the downloaded folders inside it.
+
 Run `make help` to see available commands

crates/vm/levm/src/errors.rs

@@ -32,6 +32,7 @@ pub enum VMError {
     NonceOverflow,
 }
 
+#[derive(Debug, Clone)]
 pub enum OpcodeSuccess {
     Continue,
     Result(ResultReason),

crates/vm/levm/src/opcode_handlers/system.rs

@@ -1,6 +1,6 @@
 use crate::{
     constants::{call_opcode, SUCCESS_FOR_RETURN},
-    errors::ResultReason,
+    errors::ResultReason, vm::word_to_address,
 };
 
 use super::*;
@@ -15,7 +15,7 @@ impl VM {
         current_call_frame: &mut CallFrame,
     ) -> Result<OpcodeSuccess, VMError> {
         let gas = current_call_frame.stack.pop()?;
-        let code_address = Address::from_low_u64_be(current_call_frame.stack.pop()?.low_u64());
+        let code_address = word_to_address(current_call_frame.stack.pop()?);
         let value = current_call_frame.stack.pop()?;
         let args_offset = current_call_frame
             .stack
@@ -95,7 +95,7 @@ impl VM {
         current_call_frame: &mut CallFrame,
     ) -> Result<OpcodeSuccess, VMError> {
         let gas = current_call_frame.stack.pop()?;
-        let code_address = Address::from_low_u64_be(current_call_frame.stack.pop()?.low_u64());
+        let code_address = word_to_address(current_call_frame.stack.pop()?);
         let value = current_call_frame.stack.pop()?;
         let args_offset = current_call_frame.stack.pop()?.try_into().unwrap();
         let args_size = current_call_frame.stack.pop()?.try_into().unwrap();
@@ -158,7 +158,7 @@ impl VM {
         current_call_frame: &mut CallFrame,
     ) -> Result<OpcodeSuccess, VMError> {
         let gas = current_call_frame.stack.pop()?;
-        let code_address = Address::from_low_u64_be(current_call_frame.stack.pop()?.low_u64());
+        let code_address = word_to_address(current_call_frame.stack.pop()?);
         let args_offset = current_call_frame.stack.pop()?.try_into().unwrap();
         let args_size = current_call_frame.stack.pop()?.try_into().unwrap();
         let ret_offset = current_call_frame.stack.pop()?.try_into().unwrap();
@@ -192,7 +192,7 @@ impl VM {
         current_call_frame: &mut CallFrame,
     ) -> Result<OpcodeSuccess, VMError> {
         let gas = current_call_frame.stack.pop()?;
-        let code_address = Address::from_low_u64_be(current_call_frame.stack.pop()?.low_u64());
+        let code_address = word_to_address(current_call_frame.stack.pop()?);
         let args_offset = current_call_frame.stack.pop()?.try_into().unwrap();
         let args_size = current_call_frame.stack.pop()?.try_into().unwrap();
         let ret_offset = current_call_frame.stack.pop()?.try_into().unwrap();

crates/vm/levm/src/vm.rs

@@ -9,13 +9,14 @@ use ethereum_rust_rlp;
 use ethereum_rust_rlp::encode::RLPEncode;
 use ethereum_types::H160;
 use keccak_hash::keccak;
+use serde::{Deserialize, Serialize};
 use sha3::{Digest, Keccak256};
 use std::{
     collections::{HashMap, HashSet},
     str::FromStr,
 };
 
-#[derive(Clone, Default, Debug, PartialEq, Eq)]
+#[derive(Clone, Default, Debug, PartialEq, Eq, Serialize, Deserialize)]
 pub struct Account {
     pub address: Address,
     pub balance: U256,
@@ -24,7 +25,7 @@ pub struct Account {
     pub nonce: u64,
 }
 
-#[derive(Debug, Clone, Default, PartialEq, Eq)]
+#[derive(Debug, Clone, Default, PartialEq, Eq, Serialize, Deserialize)]
 pub struct StorageSlot {
     pub original_value: U256,
     pub current_value: U256,
@@ -154,7 +155,7 @@ impl Db {
 #[derive(Debug, Clone, Default)]
 // TODO: https://github.com/lambdaclass/ethereum_rust/issues/604
 pub struct Substate {
-    pub warm_addresses: HashSet<Address>,
+    pub warm_addresses: HashSet<Address>, // Should be a hashmap <Address, AccountInfo>
 }
 
 #[derive(Debug, Default, Clone)]
@@ -366,11 +367,10 @@ impl VM {
         if contract_code.len() > MAX_CODE_SIZE {
             return Err(VMError::ContractOutputTooBig);
         }
-        // Supposing contract code has contents
-        if contract_code[0] == INVALID_CONTRACT_PREFIX {
+
+        if !contract_code.is_empty() && contract_code[0] == INVALID_CONTRACT_PREFIX {
             return Err(VMError::InvalidInitialByte);
         }
-
         // If the initialization code completes successfully, a final contract-creation cost is paid,
         // the code-deposit cost, c, proportional to the size of the created contract’s code
         let creation_cost = 200 * contract_code.len();