Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(l1, l2, levm): fix shared dependencies in workspace Cargo.toml #1680

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

refactor(l1, l2, levm): fix shared dependencies in workspace Cargo.toml #1680

wants to merge 9 commits into from

Conversation

ilitteri
Copy link
Contributor

  • Fix shared dependencies in workspace Cargo.toml
  • Separate them in three blocks
    • ethrex libs
    • worspace libs (the ones shared between different crates)
    • non-shared libs
  • Update serde_json version
  • Update serde version
  • Update bytes version

@ilitteri
Move common crates to workspace
26b5675
@ilitteri
Sort deps
fd847d2 
1. ethrex deps
2. workspace deps
3. subcrate dep
@ilitteri
Remove space
012dda6
@ilitteri ilitteri added levm Lambda EVM implementation L2 L1 labels Jan 10, 2025
@ilitteri ilitteri self-assigned this Jan 10, 2025
@ilitteri ilitteri requested a review from a team as a code owner January 10, 2025 14:07
@github-actions GitHub Actions
Copy link

The amount of lines of code in the project has not changed.

@ilitteri ilitteri marked this pull request as draft January 10, 2025 14:26
fborello-lambda
fborello-lambda approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@fborello-lambda fborello-lambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, one comment regarding the l2 crate

crates/l2/prover/zkvm/interface/Cargo.toml Outdated Show resolved Hide resolved
@ilitteri ilitteri marked this pull request as ready for review January 10, 2025 15:03
@github-actions GitHub Actions
Copy link

The amount of lines of code in the project has not changed.

1 similar comment
@github-actions GitHub Actions
Copy link

The amount of lines of code in the project has not changed.

@github-actions GitHub Actions
Copy link

The amount of lines of code in the project has not changed.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2025 •
edited
Loading

Benchmark Results Comparison

PR Results

Benchmark Results: Factorial

Command Mean [s] Min [s] Max [s] Relative
revm_factorial 7.315 ± 0.074 7.243 7.488 1.00
levm_factorial 26.600 ± 0.202 26.345 26.855 3.64 ± 0.05

Benchmark Results: Fibonacci

Command Mean [s] Min [s] Max [s] Relative
revm_fibonacci 7.167 ± 0.015 7.143 7.196 1.00
levm_fibonacci 24.329 ± 0.131 24.183 24.526 3.39 ± 0.02

Main Results

Benchmark Results: Factorial

Command Mean [s] Min [s] Max [s] Relative
revm_factorial 7.039 ± 0.055 7.006 7.187 1.00
levm_factorial 26.841 ± 0.833 26.350 29.172 3.81 ± 0.12

Benchmark Results: Fibonacci

Command Mean [s] Min [s] Max [s] Relative
revm_fibonacci 7.541 ± 0.724 7.206 9.596 1.00
levm_fibonacci 24.357 ± 0.152 24.183 24.671 3.23 ± 0.31

mpaulucci
mpaulucci reviewed Jan 10, 2025
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

The amount of lines of code in the project has not changed.

1 similar comment
@github-actions GitHub Actions
Copy link

The amount of lines of code in the project has not changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpaulucci mpaulucci mpaulucci left review comments

@fborello-lambda fborello-lambda fborello-lambda approved these changes

@fmoletta fmoletta Awaiting requested review from fmoletta

Assignees

@ilitteri ilitteri

Labels
L1 L2 levm Lambda EVM implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilitteri @mpaulucci @fborello-lambda