Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(levm): fix remaining hive tests execution with LEVM #1604

Merged
merged 3 commits into from
Jan 3, 2025
Merged

fix(levm): fix remaining hive tests execution with LEVM #1604

merged 3 commits into from
Jan 3, 2025

Conversation

JereSalo
Copy link
Contributor

@JereSalo JereSalo commented Jan 2, 2025

Motivation

Everything looked fine but some engine tests were failing.

Description

  • It seems that the tests that were failing were doing so because of error handling when interacting with our VM. We had to map the VM error to the error type that we use in L1 for representing errors in VM execution.

@JereSalo JereSalo added ef-tests Hive tests, execution-spec-tests levm Lambda EVM implementation labels Jan 2, 2025
@JereSalo JereSalo self-assigned this Jan 2, 2025
@JereSalo JereSalo marked this pull request as ready for review January 3, 2025 12:39
@JereSalo JereSalo requested a review from a team as a code owner January 3, 2025 12:39
@ilitteri ilitteri added this pull request to the merge queue Jan 3, 2025
Merged via the queue into main with commit 5fe288a Jan 3, 2025
18 checks passed
@ilitteri ilitteri deleted the levm/hive_tests_error_handling branch January 3, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilitteri ilitteri ilitteri approved these changes

Assignees

@JereSalo JereSalo

Labels
ef-tests Hive tests, execution-spec-tests levm Lambda EVM implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JereSalo @ilitteri