feat(levm): run hive tests with levm, generate and publish report #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Basic tx now works as expected
…thereum_rust into levm/fixes_cache_db
This reverts commit 58d42b0.
JereSalo
changed the title
**Motivation** <!-- Why does this pull request exist? What are its goals? --> Publish results of running Hive tests with LEVM to slack channel **Description** <!-- A clear and concise general description of the changes this PR introduces --> - We build the client image with LEVM, we run hive tests and then we publish them - Add to the Dockerfile the possibility to add build flags. - Avoid panicking if setup wasn't completed successfully, as no tests will run in that scenario.
JereSalo
changed the title
ilitteri
reviewed
Dec 27, 2024
crates/blockchain/Cargo.toml
Outdated
| @@ -28,6 +28,7 @@ path = "./blockchain.rs" | |||
|
|
|||
| [features] | |||
| default = ["c-kzg"] | |||
| default-levm = ["default", "levm"] | |||
There was a problem hiding this comment.
Let's name the target to levm
Suggested change
| default-levm = ["default", "levm"] | |
| levm = ["default", "levm"] |
There was a problem hiding this comment.
There is already a levm target
levm = ["ethrex-vm/levm"]
Do you think I should just do: levm = ["default", "ethrex-vm/levm"]?
ilitteri
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
We now can execute multiple transactions in a block and commit them after execution of them all.
It refactors
get_state_transitions_levm, now inaccount_updateswe'll have only the things that have changed from the account, so that we don't have much redundant informationWe build the client image with LEVM, we run hive tests and then we publish them
Add to the Dockerfile the possibility to add build flags.
Avoid panicking if setup wasn't completed successfully, as no tests will run in that scenario.
We can run tests with hive but the problem is that these tests execute a lot of blocks at the beginning and we usually fail at some block because of a difference in state, I tried debugging some tests and I fixed some things in other PRs but at some point I got stuck and decided that it was a better idea to leave it as is and merge this to main.