feat(l1): fetch random peer + filter by supported capability #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When choosing a peer for backend uses (such as syncing) we need to fetch a random peer and guarantee that its has an active connection and that it supports the capability needed
Description
PeerDataget_peerfunction so that it fetches a random peer and also receives a capability that the selected peer must supportFollow-Up Work & Ideas
We could implement a
PeerManagerthat holds a reference to the kademlia table and is in charge of selecting a suitable peer and performing the requests (instead of selecting a peer and calling a request_ method from the backend). This will allow us to further abstract p2p logic from other backend processes & also implement penalizations for peers returning invalid responsesCloses #1317 #1318