feat(l1): added support for forkchoiceUpdatedV1, getPayloadV1 and newPayloadV1 #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpaulucci
approved these changes
Dec 17, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
**Motivation** The recent changes of PR #1510 require a minor modification regarding `withdrawals`. **Description** Set the `withdrawals` to `Some` to make the `block_producer` work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have
V2andV3support forforkchoiceUpdated,getPayloadandnewPayload. In order to complete post-merge support we need to addV1versions for these messages.Description
Adds
V1support forforkchoiceUpdated,getPayloadandnewPayload.This makes 103 tests from hive's
engine-apito pass.Closes #1182, #1183 and #1185