-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(l2): multiple provers in file #1477
Open
fborello-lambda
wants to merge
32
commits into
l2/multiple_provers
Choose a base branch
from
l2/multiple_provers_in_file
base: l2/multiple_provers
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to l2/multiple_provers_in_file
fborello-lambda
force-pushed
the
l2/multiple_provers_in_file
branch
from
December 12, 2024 15:20
a4f2032
to
992191a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To support multiple proving systems, we may want to store the proofs and wait to have all the needed information to send the transaction to the L1 and verify them on chain.
In the previous PR (#1466) a HashMap was proposed to store the proofs in memory, a more robust solution is needed in case the L2 node goes down. In order to avoid re-execution, the proofs can be saved in files.
Description
Closes #1060