Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(levm): ginitcodeword specification, fix gas #1402

Merged
merged 8 commits into from
Dec 5, 2024
Merged

fix(levm): ginitcodeword specification, fix gas #1402

merged 8 commits into from
Dec 5, 2024

Conversation

JereSalo
Copy link
Contributor

@JereSalo JereSalo commented Dec 4, 2024 •
edited
Loading

Motivation

Description

  • number_of_words is now calculated in a more performant way, without iterating calldata.
  • The initial_call_frame in Create is now initialized with empty bytecode and the corresponding calldata send in the transaction. -> After validations the calldata will be assigned to the bytecode and it will be erased. This is mostly for using calldata for calculating some gas costs.

Closes #1362, #1363

Running tests:

  • ✓ Summary: 1547/4100 (37.73)

@JereSalo JereSalo added the levm Lambda EVM implementation label Dec 4, 2024
@JereSalo JereSalo self-assigned this Dec 4, 2024
@JereSalo JereSalo marked this pull request as ready for review December 4, 2024 21:26
@JereSalo JereSalo requested a review from a team as a code owner December 4, 2024 21:26
maximopalopoli
maximopalopoli approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@maximopalopoli maximopalopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilitteri ilitteri added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit 6777bfb Dec 5, 2024
7 checks passed
@ilitteri ilitteri deleted the levm/ginitcodeword_specification branch December 5, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximopalopoli maximopalopoli maximopalopoli approved these changes

@ilitteri ilitteri ilitteri approved these changes

Assignees

@JereSalo JereSalo

Labels
levm Lambda EVM implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SECURITY] Non-Compliance : LEVM and Ginitcodeword Specification
3 participants
@JereSalo @ilitteri @maximopalopoli