feat(l1, l2, levm): make stats
#1361
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrchatruc
approved these changes
Dec 3, 2024
mpaulucci
reviewed
Dec 3, 2024
Makefile
Outdated
| @@ -105,3 +105,25 @@ clean-hive-logs: ## 🧹 Clean Hive logs | |||
|
|
|||
| loc: | |||
| cargo run -p loc | |||
|
|
|||
| hive-stats: | |||
| git clone --quiet --single-branch --branch master --shallow-since=$(HIVE_SHALLOW_SINCE) https://github.com/lambdaclass/hive || true | |||
There was a problem hiding this comment.
why don't you add a dependency to setup-hive instead of duplicating code?
There was a problem hiding this comment.
You're right, I'll refactor it.
mpaulucci
reviewed
Dec 5, 2024
| git checkout master && \ | ||
| git fetch --shallow-since=$(HIVE_SHALLOW_SINCE) && \ | ||
| git checkout --detach $(HIVE_REVISION) && go build . ;\ | ||
| if [ "$(QUIET)" = "true" ]; then \ |
There was a problem hiding this comment.
nit
if [ "$(QUIET)" = "true" ]; then
quiet_opt="--quiet"
fi
git checkout $quiet_opt master && \
git fetch $quiet_opt --shallow-since="${HIVE_SHALLOW_SINCE}" && \
git checkout $quiet_opt --detach "${HIVE_REVISION}" && \
There was a problem hiding this comment.
or more succint:
quiet_opt=$([ "$(QUIET)" = "true" ] && echo "--quiet")
git checkout $quiet_opt master && \
git fetch $quiet_opt --shallow-since="${HIVE_SHALLOW_SINCE}" && \
git checkout $quiet_opt --detach "${HIVE_REVISION}" && \
mpaulucci
reviewed
Dec 5, 2024
| cd hive && ./hive --sim $(SIMULATION) --client ethrex --sim.limit "$(TEST_PATTERN)" | ||
| cd hive && ./hive --client ethrex --sim $(SIMULATION) --sim.limit "$(TEST_PATTERN)" | ||
|
|
||
| run-hive-all: build-image setup-hive ## 🧪 Run all Hive testing suites |
There was a problem hiding this comment.
you don't need this, you should be able to just use run-hive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to be able to run all the repo statistics locally with one command (
make stats).Description
locbin (lines of code reporter).statstarget to the Makefile that runs:Work in progress
Right now, the hive reporter needs some improvements. If you run the command
make stats,it will run all and print the reports for lines of code, LEVM EF Tests, and Hive, but the Hive report is off.Try it yourself