feat(levm): improve LEVM EF Tests report #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ilitteri
commented
Nov 28, 2024
•
ilitteri
commented
- Do not use colors in txt report printing
- If the same account was updated in LEVM but not in REVM and there's no diff, print so
- Print post state roots mismatch
- Improve LEVM state transition function
JereSalo
reviewed
Dec 2, 2024
| let current_bytecode = current_db | ||
| .get_account_code(potential_new_bytecode_hash) | ||
| .expect("Error getting account code by hash"); | ||
| let code = account.info.bytecode.clone(); |
There was a problem hiding this comment.
Suggested change
| let code = account.info.bytecode.clone(); | |
| let new_bytecode = account.info.bytecode.clone(); |
I don't know exactly why but the block of code inside the else { of let code was kinda confusing to read. I din't understand it's purpose on the first place but now I get it.
There was a problem hiding this comment.
I can add some comments explaining what is happening there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.