Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(levm): vm tests fix changes #1281

Merged
merged 38 commits into from
Nov 29, 2024
Merged

fix(levm): vm tests fix changes #1281

merged 38 commits into from
Nov 29, 2024

Conversation

maximopalopoli
Copy link
Contributor

Motivation

The goal is to make the tests of VMTests folder of EF tests.

Description

Currently, are passing 7/11 of the VMTests/vmTests folder.

Closes #issue_number

maximopalopoli and others added 4 commits November 26, 2024 09:30
This change was made when fixing a test, in which the target account
 and the current account were the same. The target, when modified
 after the current account but accessed before the modification, was
 not taking the change into account.
@maximopalopoli maximopalopoli added ef-tests Hive tests, execution-spec-tests levm Lambda EVM implementation labels Nov 26, 2024
@maximopalopoli maximopalopoli self-assigned this Nov 26, 2024
@maximopalopoli maximopalopoli marked this pull request as ready for review November 28, 2024 14:25
@maximopalopoli maximopalopoli requested a review from a team as a code owner November 28, 2024 14:25
crates/vm/levm/src/vm.rs Outdated Show resolved Hide resolved
crates/vm/levm/src/vm.rs Outdated Show resolved Hide resolved
crates/vm/levm/src/vm.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@ilitteri ilitteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good. Left some comments.

@ilitteri ilitteri self-requested a review November 28, 2024 15:45
Copy link
Contributor

@ilitteri ilitteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilitteri ilitteri enabled auto-merge November 29, 2024 16:08
@ilitteri ilitteri added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit 1208981 Nov 29, 2024
4 checks passed
@ilitteri ilitteri deleted the levm/fix/vmTests-fix-changes branch November 29, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ef-tests Hive tests, execution-spec-tests levm Lambda EVM implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants