feat(l2): fix load tests and better document load test comparisons #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fborello-lambda
approved these changes
Nov 26, 2024
xqft
approved these changes
Nov 26, 2024
Co-authored-by: Federico Borello <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 28, 2024
**Motivation** Depends on #1273 When doing flamegraphs of load tests, the node spends around 50% of its time on the `fill_transactions` function, and in there spends most of its time just calling the `sender()` method to recover the sender's address. By caching it when it's first added to the mempool, the time spent on `fill_transactions` goes down to around 8%, and block execution becomes roughly ~7x faster Before the change:  After the change:  **Description** <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description