Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(levm): set calldata as empty bytes at contract creation #1243

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

maximopalopoli
Copy link
Contributor

Motivation

Fixes a bug found by FuzzingLabs in creation type transactions.

Description

Previously, in create transactions the calldata field was set with a copy of the bytecode, which was wrong, as it should be an empty set of bytes.

Closes #1223

@maximopalopoli maximopalopoli changed the title Fix(levm): set calldata as empty bytes at contract creation fix(levm): set calldata as empty bytes at contract creation Nov 22, 2024
@maximopalopoli maximopalopoli self-assigned this Nov 22, 2024
@maximopalopoli maximopalopoli added the levm Lambda EVM implementation label Nov 22, 2024
@maximopalopoli maximopalopoli marked this pull request as ready for review November 22, 2024 21:37
@maximopalopoli maximopalopoli requested a review from a team as a code owner November 22, 2024 21:37
@ilitteri ilitteri added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit 2c63c2a Nov 25, 2024
22 of 23 checks passed
@ilitteri ilitteri deleted the levm/fix/empty-calldata-create-tx branch November 25, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
levm Lambda EVM implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SECURITY] Non-Compliance : Incorrect CALLDATASIZE Behavior During Contract Creation
2 participants