fix(l2): fix zkVM performance test #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fborello-lambda
approved these changes
Nov 19, 2024
Comment on lines
-5
to
-6
| paths: | ||
| - "crates/l2/prover/**" |
There was a problem hiding this comment.
We may trigger the CI even if it's not strictly necessary, which could make the merging process take longer. Maybe we can set it to "crates/l2/**" ?
There was a problem hiding this comment.
Agreed, let's restore this and then we can merge
There was a problem hiding this comment.
The bug was introduced because the breaking change was made in another directory, outside of crates/, I think we should be running every test each time to avoid predicting where a breaking change could occur.
There was a problem hiding this comment.
That's fair, the workflow also does not take too long so I think it's fine to leave it
jrchatruc
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This test uses the
test_data/genesis-l2.jsonandtest_data/l2-loadtest.rlpfiles. The genesis file was changed in #1158, breaking the test because now the genesis block hash changed and so the second block's parent isn't present in the chain anymore. The test only executed in the CI whenever a file incrates/l2/prover/was touched, leaving the breaking change unnoticed.Needed for #1133
Description
test_data/genesis-l2-old.json(a better solution would be to regeneratetest_data/l2-loadtest.rlp).