Skip to content

Commit

Permalink
chore(levm): ignore some json files we dont want to fix for now (#1551)
Browse files Browse the repository at this point in the history
**Motivation**

We want to ignore some tests for now, we ignore them in the code so
people don't try to fix them and waste time

**Description**

Add a list with the json files we want to ignore and skip them when
parsing.
  • Loading branch information
LeanSerra authored Dec 20, 2024
1 parent 50e7de0 commit be61c69
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions cmd/ef_tests/levm/parser.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,15 @@ pub enum EFTestParseError {
FailedToParseTestFile(String),
}

const IGNORED_TESTS: [&str; 6] = [
"ValueOverflowParis.json", // Skip because of errors
"loopMul.json", // Skip because it takes too long to run
"dynamicAccountOverwriteEmpty_Paris.json", // Skip because it fails on REVM
"RevertInCreateInInitCreate2Paris.json", // Skip because it fails on REVM
"create2collisionStorageParis.json", // Skip because it fails on REVM
"InitCollisionParis.json", // Skip because it fails on REVM
];

pub fn parse_ef_tests(opts: &EFTestRunnerOptions) -> Result<Vec<EFTest>, EFTestParseError> {
let parsing_time = std::time::Instant::now();
let cargo_manifest_dir = std::path::PathBuf::from(env!("CARGO_MANIFEST_DIR"));
Expand Down Expand Up @@ -87,11 +96,11 @@ pub fn parse_ef_test_dir(
{
continue;
}
// Skip the ValueOverflowParis.json file because of errors, and loopMul.json because it takes too long to run.
// Skip ignored tests
if test
.path()
.file_name()
.is_some_and(|name| name == "ValueOverflowParis.json" || name == "loopMul.json")
.is_some_and(|name| IGNORED_TESTS.contains(&name.to_str().unwrap_or("")))
{
continue;
}
Expand Down

0 comments on commit be61c69

Please sign in to comment.