-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor into a single crate #145
base: main
Are you sure you want to change the base?
Conversation
Benchmarking factorialCompiling factorial (factorial.con) Benchmarking fibCompiling fib (fib.con) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
==========================================
+ Coverage 54.57% 54.61% +0.04%
==========================================
Files 27 22 -5
Lines 5387 5368 -19
==========================================
- Hits 2940 2932 -8
+ Misses 2447 2436 -11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All crates have been merged into one but the project still uses the same structure, therefore it still has the same problems as before, just that it's now less of a pain to work with.
members = [ | ||
"crates/concrete", | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we just leave it as a normal crate (as opposed to having a workspace with a single crate)?
Current code locs: 8000