Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor into a single crate #145

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Refactor into a single crate #145

wants to merge 9 commits into from

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Dec 13, 2024

Current code locs: 8000

Copy link

Benchmarking factorial

Compiling factorial (factorial.con)
Finished release in 31.282353ms
Running 5000000 iterations
Using input value: 20
Concrete Result = 2432902008176640000 Time taken : 59.45 ms
Rust Result = 2432902008176640000 Time taken : 61.17 ms

Benchmarking fib

Compiling fib (fib.con)
Finished release in 26.334274ms
Running 5000 iterations
Using input value: 20
Concrete Result = 6765 Time taken : 128.68 ms
Rust Result = 6765 Time taken : 85.64 ms

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 20.20725% with 154 lines in your changes missing coverage. Please review.

Project coverage is 54.61%. Comparing base (9575fbe) to head (c90b4d3).

Files with missing lines Patch % Lines
crates/concrete/src/parser/error.rs 0.00% 92 Missing ⚠️
crates/concrete/src/codegen/compiler.rs 48.33% 31 Missing ⚠️
crates/concrete/src/check/mod.rs 0.00% 16 Missing ⚠️
crates/concrete/src/driver/mod.rs 0.00% 12 Missing ⚠️
crates/concrete/src/check/linearity_check.rs 0.00% 1 Missing ⚠️
crates/concrete/src/main.rs 0.00% 1 Missing ⚠️
crates/concrete/src/parser/mod.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   54.57%   54.61%   +0.04%     
==========================================
  Files          27       22       -5     
  Lines        5387     5368      -19     
==========================================
- Hits         2940     2932       -8     
+ Misses       2447     2436      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@azteca1998 azteca1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All crates have been merged into one but the project still uses the same structure, therefore it still has the same problems as before, just that it's now less of a pain to work with.

Comment on lines +4 to +6
members = [
"crates/concrete",
]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we just leave it as a normal crate (as opposed to having a workspace with a single crate)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants