-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array Codegen #119
Merged
Merged
Array Codegen #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JulianGCalderon
commented
Apr 26, 2024
- Adds lowering for storing and loading with both constant index and dynamic index.
- Adds example of array usage.
- Test the example against the expected output.
Benchmarking factorial |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## array-lowering #119 +/- ##
==================================================
+ Coverage 58.23% 61.28% +3.04%
==================================================
Files 34 34
Lines 4317 4388 +71
==================================================
+ Hits 2514 2689 +175
+ Misses 1803 1699 -104 ☔ View full report in Codecov by Sentry. |
Closed
edg-l
approved these changes
Apr 30, 2024
igaray
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.