Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cairo to 2.10rc-0 #986

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

update cairo to 2.10rc-0 #986

wants to merge 19 commits into from

Conversation

FrancoGiachetta
Copy link
Contributor

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

github-actions bot commented Dec 26, 2024

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
base dict_insert.cairo (JIT) 4.104 ± 0.054 4.003 4.172 1.00
base dict_insert.cairo (AOT) 4.298 ± 0.054 4.223 4.394 1.05 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head dict_insert.cairo (JIT) 3.785 ± 0.019 3.752 3.813 1.00
head dict_insert.cairo (AOT) 3.947 ± 0.021 3.903 3.978 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_snapshot.cairo (JIT) 4.272 ± 0.047 4.169 4.331 1.00
base dict_snapshot.cairo (AOT) 4.383 ± 0.037 4.322 4.444 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head dict_snapshot.cairo (JIT) 4.009 ± 0.022 3.981 4.050 1.00
head dict_snapshot.cairo (AOT) 4.166 ± 0.030 4.120 4.212 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 4.252 ± 0.033 4.202 4.307 1.00
base factorial_2M.cairo (AOT) 4.451 ± 0.037 4.413 4.534 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head factorial_2M.cairo (JIT) 4.022 ± 0.019 3.984 4.046 1.00
head factorial_2M.cairo (AOT) 4.261 ± 0.047 4.208 4.361 1.06 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 3.821 ± 0.037 3.784 3.905 1.00
base fib_2M.cairo (AOT) 4.016 ± 0.038 3.942 4.095 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head fib_2M.cairo (JIT) 3.588 ± 0.029 3.551 3.647 1.00
head fib_2M.cairo (AOT) 3.771 ± 0.025 3.731 3.825 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search.cairo (JIT) 3.967 ± 0.024 3.938 4.005 1.00
base linear_search.cairo (AOT) 4.127 ± 0.050 4.031 4.201 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head linear_search.cairo (JIT) 3.753 ± 0.018 3.727 3.786 1.00
head linear_search.cairo (AOT) 3.860 ± 0.012 3.843 3.881 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 4.148 ± 0.050 4.046 4.223 1.00
base logistic_map.cairo (AOT) 4.239 ± 0.036 4.161 4.292 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head logistic_map.cairo (JIT) 3.858 ± 0.020 3.833 3.887 1.00
head logistic_map.cairo (AOT) 3.921 ± 0.021 3.886 3.952 1.02 ± 0.01

Copy link

github-actions bot commented Dec 26, 2024

Benchmarking results

Benchmark for program dict_insert

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 20.946 ± 0.089 20.836 21.137 99.04 ± 1.71
cairo-native (embedded AOT) 4.018 ± 0.022 3.998 4.074 19.00 ± 0.34
cairo-native (embedded JIT using LLVM's ORC Engine) 3.860 ± 0.027 3.826 3.910 18.25 ± 0.33
cairo-native (standalone AOT with -march=native) 0.211 ± 0.004 0.207 0.217 1.00

Benchmark for program dict_snapshot

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.832 ± 0.034 5.782 5.885 18.10 ± 0.32
cairo-native (embedded AOT) 4.179 ± 0.028 4.132 4.224 12.97 ± 0.24
cairo-native (embedded JIT using LLVM's ORC Engine) 4.052 ± 0.019 4.023 4.080 12.58 ± 0.22
cairo-native (standalone AOT with -march=native) 0.322 ± 0.005 0.317 0.330 1.00

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.951 ± 0.082 14.837 15.100 11.01 ± 0.06
cairo-native (embedded AOT) 4.309 ± 0.023 4.276 4.347 3.17 ± 0.02
cairo-native (embedded JIT using LLVM's ORC Engine) 4.078 ± 0.016 4.056 4.106 3.00 ± 0.01
cairo-native (standalone AOT with -march=native) 1.359 ± 0.002 1.357 1.365 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.847 ± 0.049 14.763 14.916 182.84 ± 0.78
cairo-native (embedded AOT) 3.823 ± 0.025 3.794 3.878 47.08 ± 0.33
cairo-native (embedded JIT using LLVM's ORC Engine) 3.614 ± 0.027 3.581 3.663 44.50 ± 0.36
cairo-native (standalone AOT with -march=native) 0.081 ± 0.000 0.081 0.082 1.00

Benchmark for program linear_search

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.838 ± 0.022 5.810 5.880 2854.47 ± 60.53
cairo-native (embedded AOT) 3.910 ± 0.022 3.887 3.951 1911.92 ± 41.26
cairo-native (embedded JIT using LLVM's ORC Engine) 3.811 ± 0.015 3.788 3.839 1863.71 ± 39.57
cairo-native (standalone AOT with -march=native) 0.002 ± 0.000 0.002 0.002 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.784 ± 0.068 5.698 5.894 23.84 ± 0.29
cairo-native (embedded AOT) 3.988 ± 0.014 3.972 4.010 16.44 ± 0.08
cairo-native (embedded JIT using LLVM's ORC Engine) 3.897 ± 0.020 3.872 3.943 16.06 ± 0.10
cairo-native (standalone AOT with -march=native) 0.243 ± 0.001 0.242 0.245 1.00

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 80.90%. Comparing base (e41f7b1) to head (185e94b).

Files with missing lines Patch % Lines
src/libfuncs/gas.rs 88.88% 7 Missing ⚠️
src/libfuncs/bounded_int.rs 97.32% 3 Missing ⚠️
src/debug.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #986      +/-   ##
==========================================
+ Coverage   80.76%   80.90%   +0.14%     
==========================================
  Files         107      107              
  Lines       29256    29428     +172     
==========================================
+ Hits        23628    23809     +181     
+ Misses       5628     5619       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 27, 2024

✅ Code is now correctly formatted.

azteca1998
azteca1998 previously approved these changes Dec 27, 2024
src/libfuncs/bounded_int.rs Outdated Show resolved Hide resolved
src/libfuncs/gas.rs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants