-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix --no-default-features
library-only builds.
#984
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azteca1998
requested review from
edg-l,
igaray,
jrchatruc,
entropidelic,
fmoletta,
Oppen,
pefontana and
gabrielbosio
as code owners
December 20, 2024 15:40
Benchmark results Main vs HEAD.
|
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
20.538 ± 0.144 | 20.377 | 20.876 | 100.84 ± 2.14 |
cairo-native (embedded AOT) |
3.932 ± 0.019 | 3.913 | 3.981 | 19.30 ± 0.40 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.773 ± 0.012 | 3.752 | 3.789 | 18.53 ± 0.38 |
cairo-native (standalone AOT with -march=native) |
0.204 ± 0.004 | 0.199 | 0.216 | 1.00 |
Benchmark for program dict_snapshot
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
5.636 ± 0.013 | 5.609 | 5.653 | 17.82 ± 0.12 |
cairo-native (embedded AOT) |
4.104 ± 0.018 | 4.079 | 4.138 | 12.98 ± 0.10 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.963 ± 0.014 | 3.941 | 3.981 | 12.53 ± 0.09 |
cairo-native (standalone AOT with -march=native) |
0.316 ± 0.002 | 0.313 | 0.320 | 1.00 |
Benchmark for program factorial_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
14.018 ± 0.074 | 13.917 | 14.140 | 10.39 ± 0.06 |
cairo-native (embedded AOT) |
4.353 ± 0.093 | 4.274 | 4.600 | 3.23 ± 0.07 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
4.098 ± 0.079 | 4.017 | 4.279 | 3.04 ± 0.06 |
cairo-native (standalone AOT with -march=native) |
1.349 ± 0.001 | 1.346 | 1.351 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
14.441 ± 0.091 | 14.294 | 14.589 | 185.47 ± 6.03 |
cairo-native (embedded AOT) |
3.727 ± 0.033 | 3.685 | 3.794 | 47.86 ± 1.59 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.499 ± 0.013 | 3.479 | 3.524 | 44.94 ± 1.44 |
cairo-native (standalone AOT with -march=native) |
0.078 ± 0.002 | 0.077 | 0.093 | 1.00 |
Benchmark for program linear_search
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
5.634 ± 0.023 | 5.611 | 5.687 | 2846.21 ± 60.74 |
cairo-native (embedded AOT) |
3.853 ± 0.024 | 3.816 | 3.884 | 1946.27 ± 42.48 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.764 ± 0.026 | 3.720 | 3.800 | 1901.54 ± 41.87 |
cairo-native (standalone AOT with -march=native) |
0.002 ± 0.000 | 0.002 | 0.002 | 1.00 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
5.523 ± 0.023 | 5.497 | 5.562 | 22.74 ± 0.14 |
cairo-native (embedded AOT) |
3.887 ± 0.015 | 3.871 | 3.924 | 16.00 ± 0.10 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.809 ± 0.014 | 3.790 | 3.836 | 15.69 ± 0.09 |
cairo-native (standalone AOT with -march=native) |
0.243 ± 0.001 | 0.242 | 0.246 | 1.00 |
gabrielbosio
approved these changes
Dec 20, 2024
FrancoGiachetta
approved these changes
Dec 20, 2024
edg-l
approved these changes
Dec 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #984 +/- ##
==========================================
- Coverage 80.76% 80.75% -0.01%
==========================================
Files 107 107
Lines 29256 29256
==========================================
- Hits 23628 23627 -1
- Misses 5628 5629 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few issues were preventing minimal builds from succeeding:
All those issues have been fixed.
Checklist