-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce daily block range size to 10 #973
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #973 +/- ##
=======================================
Coverage 80.66% 80.66%
=======================================
Files 107 107
Lines 29325 29325
=======================================
Hits 23656 23656
Misses 5669 5669 ☔ View full report in Codecov by Sentry. |
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.220 ± 0.193 | 10.750 | 11.478 | 8.33 ± 0.14 |
cairo-native (embedded AOT) |
3.348 ± 0.013 | 3.331 | 3.370 | 2.49 ± 0.01 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.146 ± 0.016 | 3.119 | 3.163 | 2.34 ± 0.01 |
cairo-native (standalone AOT with -march=native) |
1.346 ± 0.001 | 1.344 | 1.348 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
10.597 ± 0.321 | 10.341 | 11.250 | 136.56 ± 4.15 |
cairo-native (embedded AOT) |
2.968 ± 0.049 | 2.901 | 3.040 | 38.25 ± 0.64 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.733 ± 0.048 | 2.692 | 2.858 | 35.22 ± 0.63 |
cairo-native (standalone AOT with -march=native) |
0.078 ± 0.000 | 0.077 | 0.078 | 1.00 |
Benchmark for program linear_search
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.317 ± 0.038 | 4.261 | 4.367 | 2199.88 ± 47.36 |
cairo-native (embedded AOT) |
3.024 ± 0.016 | 3.004 | 3.054 | 1541.05 ± 31.29 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.924 ± 0.015 | 2.895 | 2.942 | 1489.98 ± 30.22 |
cairo-native (standalone AOT with -march=native) |
0.002 ± 0.000 | 0.002 | 0.002 | 1.00 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.197 ± 0.016 | 4.165 | 4.223 | 17.28 ± 0.09 |
cairo-native (embedded AOT) |
3.110 ± 0.029 | 3.079 | 3.178 | 12.80 ± 0.13 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.031 ± 0.018 | 3.004 | 3.059 | 12.48 ± 0.09 |
cairo-native (standalone AOT with -march=native) |
0.243 ± 0.001 | 0.242 | 0.245 | 1.00 |
Benchmark results Main vs HEAD.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now we are running 40 workflows, with 25 blocks each, summing up to a total of 1000 blocks each day. If we reduce the range size, we should also increase the number of workflows so that we run more or less the same amount of blocks.
Also, maybe a range size of 10 to little, maybe we could try with 20 and see if it finishes in time.
I would say it's preferable to have more blocks and leave it to 10 to be sure it won't fail. Looking at the number of transactions that fail, I think 10 blocks range should have us covered. What do you think? |
@FrancoGiachetta 10 blocks will probably work, but if it fails with 20 (or 15), we could make another PR lowering it a bit more, right? There is a limit to the amount of jobs that can be run in a workflow, so there is a benefit on trying to find the maximum range size that will run all blocks, just in case later on we want to increase the size of the daily run. |
If I'm not mistaken, the limit of workers is 256. But yeah, we could definitely give it a try. |
To reduce the timeout chance, daily block running is more a health check, so if it fails due to timeout its pointless
Checklist