Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SafeRunner to catch SIGSEGV and grow the stack automagically. #959

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

azteca1998
Copy link
Collaborator

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

github-actions bot commented Dec 5, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.931 ± 0.383 10.428 11.321 8.10 ± 0.28
cairo-native (embedded AOT) 3.385 ± 0.011 3.373 3.407 2.51 ± 0.01
cairo-native (embedded JIT using LLVM's ORC Engine) 3.204 ± 0.016 3.183 3.228 2.37 ± 0.01
cairo-native (standalone AOT with -march=native) 1.349 ± 0.003 1.347 1.355 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.623 ± 0.272 10.356 11.194 136.31 ± 3.68
cairo-native (embedded AOT) 2.944 ± 0.024 2.907 2.993 37.77 ± 0.45
cairo-native (embedded JIT using LLVM's ORC Engine) 2.754 ± 0.022 2.727 2.792 35.34 ± 0.41
cairo-native (standalone AOT with -march=native) 0.078 ± 0.001 0.077 0.082 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.253 ± 0.036 4.212 4.327 17.50 ± 0.18
cairo-native (embedded AOT) 3.117 ± 0.016 3.098 3.140 12.83 ± 0.10
cairo-native (embedded JIT using LLVM's ORC Engine) 3.047 ± 0.020 3.021 3.079 12.54 ± 0.11
cairo-native (standalone AOT with -march=native) 0.243 ± 0.001 0.242 0.246 1.00

Copy link

github-actions bot commented Dec 5, 2024

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 3.231 ± 0.035 3.187 3.277 1.00
base factorial_2M.cairo (AOT) 3.381 ± 0.016 3.350 3.411 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head factorial_2M.cairo (JIT) 3.186 ± 0.022 3.163 3.232 1.00
head factorial_2M.cairo (AOT) 3.378 ± 0.022 3.342 3.416 1.06 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 2.743 ± 0.020 2.715 2.769 1.00
base fib_2M.cairo (AOT) 2.939 ± 0.018 2.908 2.974 1.07 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head fib_2M.cairo (JIT) 2.750 ± 0.023 2.692 2.775 1.00
head fib_2M.cairo (AOT) 2.933 ± 0.016 2.899 2.959 1.07 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 3.042 ± 0.019 3.005 3.060 1.00
base logistic_map.cairo (AOT) 3.107 ± 0.021 3.073 3.138 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head logistic_map.cairo (JIT) 3.036 ± 0.017 3.011 3.057 1.00
head logistic_map.cairo (AOT) 3.082 ± 0.022 3.046 3.121 1.02 ± 0.01

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 92.80303% with 19 lines in your changes missing coverage. Please review.

Project coverage is 82.62%. Comparing base (2bad480) to head (efbceb0).

Files with missing lines Patch % Lines
src/utils/safe_runner.rs 92.80% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #959      +/-   ##
==========================================
+ Coverage   82.54%   82.62%   +0.08%     
==========================================
  Files         117      118       +1     
  Lines       33516    33780     +264     
==========================================
+ Hits        27666    27911     +245     
- Misses       5850     5869      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants